Re: [PATCH v5 04/23] scsi: sd: Differentiate system and runtime start/stop management

[Damien Le Moal <dlemoal@kernel.org>]

On 2023/09/21 18:25, Martin K. Petersen wrote:
> 
> Damien,
> 
> Just a few minor nits...
> 
>> The underlying device and driver of a scsi disk may have different
> 
> Maybe it's just me, but I always trip over lowercase "scsi". And you
> write ATA in upper case...
> 
>> device will also be suspended and resumed, with the resum operation
> 
> resume
> 
>> requiring re-validating the device link and the device itseld. In this
> 
> itself
> 
>> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
>> index c92a317ba547..1d106c8ad5af 100644
>> --- a/drivers/scsi/sd.c
>> +++ b/drivers/scsi/sd.c
>> @@ -201,18 +201,50 @@ cache_type_store(struct device *dev, struct device_attribute *attr,
>>  }
>>  
>>  static ssize_t
>> -manage_start_stop_show(struct device *dev, struct device_attribute *attr,
>> -		       char *buf)
> 
> Shouldn't we leave this for backwards compatibility?

Good point. But what should it show/control ? Both system & runtime flags (show
a AND of the flag and set/reset both flags ?). Or make it read-only and show a
AND of both flags ?

-- 
Damien Le Moal
Western Digital Research