From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Magenheimer Subject: RE: Re: Xenheap disappearance: (was: xen_phys_start for 32b) Date: Thu, 15 Jan 2009 18:15:53 +0000 (GMT) Message-ID: <96d6ebb0-6ee2-494b-8a53-da25eba119d2@default> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="__12320433667116000acsmt702.oracle.com" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --__12320433667116000acsmt702.oracle.com Content-Type: text/plain; charset=Windows-1252 Content-Transfer-Encoding: quoted-printable > Xmalloc/xfree can use alloc_domheap_pages always on x86/64. > A temporary > ifdef inside xmalloc is better than an extra xmalloc interface. OK, I see. So what you want is xmalloc to be the only interface. And "temporary" means until Xen no longer supports 32-bit at all? Will you take this patch then? I think this patch meets your objectives and is greatly simplified. > Also, this will be a small patch you can carry in your own > patchset for now. I'm just trying to contribute to your stated objective: > Xenheap will disappear entirely on x86/64 in future. and trying to get the syntax/semantics pinned down. Is this not what you intended to implement for 3.4? Or did you have something entirely different in mind? Thanks, Dan Signed-off-by: Dan Magenheimer --__12320433667116000acsmt702.oracle.com Content-Type: application/octet-stream; name="xmalloc.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xmalloc.patch" ZGlmZiAtciA0ZjZhMmJiZGZmM2YgeGVuL2NvbW1vbi94bWFsbG9jX3Rsc2YuYwotLS0gYS94ZW4v Y29tbW9uL3htYWxsb2NfdGxzZi5jCVR1ZSBKYW4gMTMgMTU6NTM6NDcgMjAwOSArMDAwMAorKysg Yi94ZW4vY29tbW9uL3htYWxsb2NfdGxzZi5jCVRodSBKYW4gMTUgMTA6NDI6MDMgMjAwOSAtMDcw MApAQCAtMjgzLDYgKzI4MywzOSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgQUREX1JFR0lPTih2b2lk ICpyZWdpCiAgKiBUTFNGIHBvb2wtYmFzZWQgYWxsb2NhdG9yIHN0YXJ0LgogICovCiAKKyNpZmRl ZiBfX3g4Nl82NF9fCitleHRlcm4gdm9pZCBmcmVlX2RvbWhlYXBfcGFnZXMoc3RydWN0IHBhZ2Vf aW5mbyAqcGcsIHVuc2lnbmVkIGludCBvcmRlcik7CitleHRlcm4gc3RydWN0IHBhZ2VfaW5mbyAq YWxsb2NfZG9taGVhcF9wYWdlcygKKyAgICBzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBpbnQg b3JkZXIsIHVuc2lnbmVkIGludCBtZW1mbGFncyk7CisKK3N0YXRpYyBpbmxpbmUgdm9pZCAqYWxs b2NfeGhlYXBfcGFnZXModW5zaWduZWQgaW50IG9yZGVyKQoreworICAgIHN0cnVjdCBwYWdlX2lu Zm8gKnBpID0gMDsKKworICAgIGlmICgocGkgPSBhbGxvY19kb21oZWFwX3BhZ2VzKDAsb3JkZXIs MCkpID09IE5VTEwpCisgICAgICAgIHJldHVybiBOVUxMOworICAgIHJldHVybiBtZm5fdG9fdmly dChwYWdlX3RvX21mbihwaSkpOworfQorCitzdGF0aWMgaW5saW5lIHZvaWQgZnJlZV94aGVhcF9w YWdlcyh2b2lkICpwLCB1bnNpZ25lZCBpbnQgb3JkZXIpCit7CisgICAgZnJlZV9kb21oZWFwX3Bh Z2VzKG1mbl90b19wYWdlKHZpcnRfdG9fbWZuKHApKSxvcmRlcik7Cit9CisjZWxzZQorZXh0ZXJu IHZvaWQgZnJlZV94ZW5oZWFwX3BhZ2VzKHZvaWQgKnAsIHVuc2lnbmVkIGludCBvcmRlcik7Citl eHRlcm4gdm9pZCAqYWxsb2NfeGVuaGVhcF9wYWdlcyh1bnNpZ25lZCBpbnQgb3JkZXIpOworCitz dGF0aWMgaW5saW5lIHZvaWQgKmFsbG9jX3hoZWFwX3BhZ2VzKHVuc2lnbmVkIGludCBvcmRlcikK K3sKKyAgICByZXR1cm4gKHZvaWQgKilhbGxvY194ZW5oZWFwX3BhZ2VzKG9yZGVyKTsKK30KKwor c3RhdGljIGlubGluZSB2b2lkIGZyZWVfeGhlYXBfcGFnZXModm9pZCAqcCwgdW5zaWduZWQgaW50 IG9yZGVyKQoreworICAgIGZyZWVfeGVuaGVhcF9wYWdlcyhwLDApOworfQorI2VuZGlmCisKIHN0 cnVjdCB4bWVtX3Bvb2wgKnhtZW1fcG9vbF9jcmVhdGUoCiAgICAgY29uc3QgY2hhciAqbmFtZSwK ICAgICB4bWVtX3Bvb2xfZ2V0X21lbW9yeSBnZXRfbWVtLApAQCAtMzAwLDcgKzMzMyw3IEBAIHN0 cnVjdCB4bWVtX3Bvb2wgKnhtZW1fcG9vbF9jcmVhdGUoCiAgICAgcG9vbF9ieXRlcyA9IFJPVU5E VVBfU0laRShzaXplb2YoKnBvb2wpKTsKICAgICBwb29sX29yZGVyID0gZ2V0X29yZGVyX2Zyb21f Ynl0ZXMocG9vbF9ieXRlcyk7CiAKLSAgICBwb29sID0gKHZvaWQgKilhbGxvY194ZW5oZWFwX3Bh Z2VzKHBvb2xfb3JkZXIpOworICAgIHBvb2wgPSAodm9pZCAqKWFsbG9jX3hoZWFwX3BhZ2VzKHBv b2xfb3JkZXIpOwogICAgIGlmICggcG9vbCA9PSBOVUxMICkKICAgICAgICAgcmV0dXJuIE5VTEw7 CiAgICAgbWVtc2V0KHBvb2wsIDAsIHBvb2xfYnl0ZXMpOwpAQCAtMzM0LDcgKzM2Nyw3IEBAIHN0 cnVjdCB4bWVtX3Bvb2wgKnhtZW1fcG9vbF9jcmVhdGUoCiAgICAgcmV0dXJuIHBvb2w7CiAKICBv dXRfcmVnaW9uOgotICAgIGZyZWVfeGVuaGVhcF9wYWdlcyhwb29sLCBwb29sX29yZGVyKTsKKyAg ICBmcmVlX3hoZWFwX3BhZ2VzKHBvb2wsIHBvb2xfb3JkZXIpOwogICAgIHJldHVybiBOVUxMOwog fQogCkBAIC01MDUsMTIgKzUzOCwxMiBAQCBzdGF0aWMgdm9pZCAqeG1hbGxvY19wb29sX2dldCh1 bnNpZ25lZCBsCiBzdGF0aWMgdm9pZCAqeG1hbGxvY19wb29sX2dldCh1bnNpZ25lZCBsb25nIHNp emUpCiB7CiAgICAgQVNTRVJUKHNpemUgPT0gUEFHRV9TSVpFKTsKLSAgICByZXR1cm4gYWxsb2Nf eGVuaGVhcF9wYWdlcygwKTsKKyAgICByZXR1cm4gYWxsb2NfeGhlYXBfcGFnZXMoMCk7CiB9CiAK IHN0YXRpYyB2b2lkIHhtYWxsb2NfcG9vbF9wdXQodm9pZCAqcCkKIHsKLSAgICBmcmVlX3hlbmhl YXBfcGFnZXMocCwwKTsKKyAgICBmcmVlX3hoZWFwX3BhZ2VzKHAsMCk7CiB9CiAKIHN0YXRpYyB2 b2lkICp4bWFsbG9jX3dob2xlX3BhZ2VzKHVuc2lnbmVkIGxvbmcgc2l6ZSkKQEAgLTUxOCw3ICs1 NTEsNyBAQCBzdGF0aWMgdm9pZCAqeG1hbGxvY193aG9sZV9wYWdlcyh1bnNpZ25lCiAgICAgc3Ry dWN0IGJoZHIgKmI7CiAgICAgdW5zaWduZWQgaW50IHBhZ2VvcmRlciA9IGdldF9vcmRlcl9mcm9t X2J5dGVzKHNpemUgKyBCSERSX09WRVJIRUFEKTsKIAotICAgIGIgPSBhbGxvY194ZW5oZWFwX3Bh Z2VzKHBhZ2VvcmRlcik7CisgICAgYiA9IGFsbG9jX3hoZWFwX3BhZ2VzKHBhZ2VvcmRlcik7CiAg ICAgaWYgKCBiID09IE5VTEwgKQogICAgICAgICByZXR1cm4gTlVMTDsKIApAQCAtNTkzLDcgKzYy Niw3IEBAIHZvaWQgeGZyZWUodm9pZCAqcCkKICAgICB9CiAKICAgICBpZiAoIGItPnNpemUgPj0g KFBBR0VfU0laRSAtICgyKkJIRFJfT1ZFUkhFQUQpKSApCi0gICAgICAgIGZyZWVfeGVuaGVhcF9w YWdlcygodm9pZCAqKWIsIGdldF9vcmRlcl9mcm9tX2J5dGVzKGItPnNpemUpKTsKKyAgICAgICAg ZnJlZV94aGVhcF9wYWdlcygodm9pZCAqKWIsIGdldF9vcmRlcl9mcm9tX2J5dGVzKGItPnNpemUp KTsKICAgICBlbHNlCiAgICAgICAgIHhtZW1fcG9vbF9mcmVlKHAsIHhlbnBvb2wpOwogfQo= --__12320433667116000acsmt702.oracle.com Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --__12320433667116000acsmt702.oracle.com--