From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.22 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793325336; b=5hEhY+ElTzYwIxYDP9qooRTPi9UeBKKYRl3DgASylcWB0TcRgN5iSd2k3XtoUntJt7oF 0rqGdhknhrbwVMLmzlMHCV8qQcqh+IDiRUFYlTqPIidlCVH1HeYvsu+APxansCuUFUDpy kx7/QFeEn+WFNqqPE+Cgly6ylT6K7rnrnDhnX9IKT7Y7pj80aOqXDBkcA5IYn6pC734Oo hIYke2sZkI6ZMpABkt5ayXXTMc4fmACjXkBU2AOfaW6sie5tygkh1E9soW/518xL9pPwB 7ioghaIfoEFKyVHidT1AFt43qv5y6nhDivIyAj4rse9EIJLpoXLpUYa2a0oJ8x54rNQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793325336; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=NW47OZGG+imSFWQTUojgxKaRsVA/dxTDAH6Z79eqPk4=; b=MZTH2RlvdMg9EwQzN1zDWeUu3ePeqeBto2kVKF/7sO/VbBCb1c5MB4CSFA3rsKN09Uij 5FYiizyZ+EByrRsxCj9wBP4zZryei+iS4T9FyH6eP1PvLv2VIYqMKfZ+wHD4sBkOhCn2f /mssnJtNP22P8HQ/Q/3d4e1LD5RTMy2RK3/keVjlfBJaxk1Eos5Zz88bKwZWOo954ef7i lznqPKFs80CAHEAYzsOcIcvs6jL18UZwQ7zihhI91loVPojsAoJ/jdXBG9olBTgj3MD8K zNK4QgXSpSuJdXGmlWjgl89FVOk5ndc6b7Z9i1asFvPFfZBO/m1Q/VXvKUXnLApgGrA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=kNOyyoQ2; arc=none smtp.remote-ip=91.218.175.22 Received: from mta0.migadu.com (out-22.mta0.migadu.com [91.218.175.22]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0A2F606A31C for ; Fri, 30 Oct 2026 01:55:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E0A2F606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=kNOyyoQ2 X-Envelope-To: bpf@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=yLibGXRg0x614xy7jj1umLLnLSoSQ8rxXuFtkSyAjTw=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793325333; v=1; x=1793930133; b=kNOyyoQ2kccYEwJSs9fkON5SJeS4BIk9be8SXVvPt/xfMMN3MLnRxEiOWuie9PmC0YFzCc61 SJbyeWhk89gYyB64YxEyiUSVuQiFDyjICqmrW9apPymR+i0hGDE8W1wmpoF9h9Fw1cX1THlK7yj 7FKJdy6fIGiX+JgaIjKpnOcY= X-Envelope-To: bpf@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 6e53ba925bba0fe2; Fri, 30 Oct 2026 01:55:29 +0000 X-Mizu-Trace-ID: 6e53ba925bba0fe2 X-Migadu-Flow: FLOW_OUT Message-ID: <96dfb9b7-1eaf-4bb2-8136-9a2478e1a068@linux.dev> Date: Fri, 30 Oct 2026 09:55:17 +0800 X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v5 5/6] libbpf: Add log_opts support for bpf_link_create To: Andrii Nakryiko Cc: bpf@vger.kernel.org, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Shuah Khan , Kuniyuki Iwashima , Hangbin Liu , Martin Karsten , Masashi Honma , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20261026154948.99408-1-leon.hwang@linux.dev> <20261026154948.99408-6-leon.hwang@linux.dev> Content-Language: en-US From: Leon Hwang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 30/10/26 00:22, Andrii Nakryiko wrote: > On Mon, Oct 26, 2026 at 8:51 AM Leon Hwang wrote: [...] >> @@ -960,12 +970,12 @@ int bpf_link_create(int prog_fd, int target_fd, >> return libbpf_err(-EINVAL); >> break; >> default: >> - if (!OPTS_ZEROED(opts, flags)) >> + if (!OPTS_ZEROED(opts, iter_info_len)) > > semantically cleaner would be to use log_opts here instead of > iter_info_len, send in a follow up? Will do. > >> return libbpf_err(-EINVAL); >> break; >> } >> proceed: >> - fd = sys_bpf_fd(BPF_LINK_CREATE, &attr, attr_sz); >> + fd = __sys_bpf_fd(BPF_LINK_CREATE, &attr, attr_sz, log_opts); >> if (fd >= 0) >> return fd; >> /* we'll get EINVAL if LINK_CREATE doesn't support attaching fentry >> @@ -975,6 +985,10 @@ int bpf_link_create(int prog_fd, int target_fd, >> if (err != -EINVAL) >> return libbpf_err(err); >> >> + /* bpf_raw_tracepoint_open() does not support log_opts */ >> + if (log_opts) >> + return libbpf_err(err); >> + >> /* if user used features not supported by >> * BPF_RAW_TRACEPOINT_OPEN command, then just give up immediately >> */ >> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h >> index 826d9cc9ab65..fe3b7fd8512b 100644 >> --- a/tools/lib/bpf/bpf.h >> +++ b/tools/lib/bpf/bpf.h >> @@ -422,7 +422,10 @@ union bpf_iter_link_info; /* defined in up-to-date linux/bpf.h */ >> struct bpf_link_create_opts { >> size_t sz; /* size of this struct for forward/backward compatibility */ >> __u32 flags; >> - union bpf_iter_link_info *iter_info; >> + union { >> + union bpf_iter_link_info *iter_info; >> + struct bpf_log_opts *log_opts; >> + }; >> __u32 iter_info_len; > > in a follow up, let's add comment next to iter_info above and > iter_info_len here that these are deprecated and that iter.info and > iter.info_len should be used instead > Will add comment when adding log_opts support for BPF_TRACE_ITER in libbpf in near future. Thanks, Leon