From: nguyenb@codeaurora.org
To: Avri Altman <Avri.Altman@wdc.com>
Cc: cang@codeaurora.org, asutoshd@codeaurora.org,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Nitin Rawat <nitirawa@codeaurora.org>,
Bean Huo <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer
Date: Mon, 31 Aug 2020 11:07:06 -0700 [thread overview]
Message-ID: <96e34a8d7d52dfbc47738f04d2a127c2@codeaurora.org> (raw)
In-Reply-To: <BY5PR04MB6705177184FC1A0E5F7710FDFC530@BY5PR04MB6705.namprd04.prod.outlook.com>
On 2020-08-29 00:32, Avri Altman wrote:
>>
>> The zero value Auto-Hibernate Timer is a valid setting, and it
>> indicates the Auto-Hibernate feature being disabled. Correctly
> Right. So " ufshcd_auto_hibern8_enable" is no longer an appropriate
> name.
> Maybe ufshcd_auto_hibern8_set instead?
Thanks for your comment. I am ok with the name change suggestion.
>
> Also, did you verified that no other platform relies on its non-zero
> value?
I only tested the change on Qualcomm's platform. I do not have other
platforms to do the test.
The UFS host controller spec JESD220E, Section 5.2.5 says
"Software writes “0” to disable Auto-Hibernate Idle Timer". So the spec
supports this zero value.
Some options:
- We could add a hba->caps so that we only apply the change for
Qualcomm's platforms.
This is not preferred because it is following the spec implementations.
- Or other platforms that do not support the zero value needs a caps.
>
> Thanks,
> Avri
next prev parent reply other threads:[~2020-08-31 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 1:05 [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer Bao D. Nguyen
2020-08-29 3:13 ` Bart Van Assche
2020-08-31 17:38 ` nguyenb
2020-08-29 7:32 ` Avri Altman
2020-08-31 18:07 ` nguyenb [this message]
2020-09-02 5:10 ` Avri Altman
2020-09-04 1:39 ` Stanley Chu
2020-09-09 2:03 ` Martin K. Petersen
2020-09-15 20:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96e34a8d7d52dfbc47738f04d2a127c2@codeaurora.org \
--to=nguyenb@codeaurora.org \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nitirawa@codeaurora.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.