From: Edward Cree <ecree.xilinx@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org
Subject: Re: [RFG] sfc: nvlog and devlink health
Date: Wed, 16 Apr 2025 11:24:07 +0100 [thread overview]
Message-ID: <96e8acf9-dbd9-6512-423e-22f52919475f@gmail.com> (raw)
In-Reply-To: <e3acvyonpwd6eejk6ka2vmkorggtnohc6vfagzix5xkx4jru6o@kf3q3hvasgtx>
On 15/04/2025 17:41, Jiri Pirko wrote:
> Tue, Apr 15, 2025 at 04:51:39PM +0200, ecree.xilinx@gmail.com wrote:
>> DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR is no use here, because it only
>> clears the kernel-saved copy; it doesn't call any driver method.
>
> Can't it be extended to actually call an optional driver method?
> That would sound fine to me and will solve your problem.
Would that be "diagnose"/"dump clear" or "dump"/"dump clear"?
The former is weird, are you sure it's not a misuse of the API to
have "dump clear" clear something that's not a dump? I feel like
extending the devlink core to support a semantic mismatch /
layering violation might raise a few eyebrows.
The latter just doesn't work as (afaict) calling dump twice
without an intervening clear won't get updated output, and users
might want to read again without erasing.
next prev parent reply other threads:[~2025-04-16 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 14:51 [RFG] sfc: nvlog and devlink health Edward Cree
2025-04-15 16:41 ` Jiri Pirko
2025-04-16 10:24 ` Edward Cree [this message]
2025-04-16 11:27 ` Jiri Pirko
2025-04-22 13:21 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96e8acf9-dbd9-6512-423e-22f52919475f@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.