All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hansg@kernel.org>
To: chitranshmandhaniya@gmail.com, ilpo.jarvinen@linux.intel.com,
	rafael@kernel.org
Cc: lenb@kernel.org, platform-driver-x86@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chitransh_Mandhaniya@dell.com
Subject: Re: [PATCH v5] ACPI: video: force native backlight on Dell OptiPlex AIO 7410 35W
Date: Mon, 12 Oct 2026 16:54:57 +0200	[thread overview]
Message-ID: <96f4dc4d-eb5c-4af2-86e4-8d10f87b3d9d@kernel.org> (raw)
In-Reply-To: <20261010124830.116750-1-chitranshmandhaniya@gmail.com>

Hi,

On 10-Oct-26 14:48, chitranshmandhaniya@gmail.com wrote:
> From: Chitransh Mandhaniya <Chitransh_Mandhaniya@dell.com>
> 
> The Dell OptiPlex AIO 7410 35W (board 01KP8D) declares DELL0501 in its
> ACPI DSDT (status = 0x0F) even though no UART scalar board is physically
> present. This causes acpi_video_get_backlight_type() to return
> acpi_backlight_dell_uart, which makes i915 skip registering
> intel_backlight. The dell-uart-backlight driver then times out talking
> to the absent board and the probe fails, leaving the machine with zero
> backlight control.
> 
> A BIOS update fixes this on some models (e.g. OptiPlex 7420, board
> 0914RT) by setting DELL0501 _STA to 0, but Dell has not shipped a
> corrected BIOS for the 7410 even in the latest release (1.37.0,
> 2026-05-28).
> 
> Add a DMI quirk to force native backlight on this model so that i915
> registers intel_backlight and brightness control works out of the box.
> 
> Tested on:
>   - OptiPlex AIO 7410 35W (01KP8D, BIOS 1.37.0) -- confirmed
>     acpi_backlight=native produces working intel_backlight (raw,
>     max=96000), DMI quirk has the same effect.
>   - OptiPlex AIO 7420 35W (0914RT, BIOS 1.27.0) -- DELL0501 absent in
>     updated BIOS, intel_backlight works natively (no regression).
> 
> Signed-off-by: Chitransh Mandhaniya <Chitransh_Mandhaniya@dell.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans




> ---
>  drivers/acpi/video_detect.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index e3b69f876d24..1af14e04e597 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -883,6 +883,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7770 AIO"),
>  		},
>  	},
> +	{
> +	 .callback = video_detect_force_native,
> +	 /* Dell OptiPlex AIO 7410 35W */
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex AIO 7410 35W"),
> +		},
> +	},
>  
>  	/*
>  	 * Models which have nvidia-ec-wmi support, but should not use it.


  reply	other threads:[~2026-10-12 14:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 14:16 [PATCH] platform/x86: dell-uart-backlight: fall back to PCH PWM on UART timeout chitranshmandhaniya
2026-10-08 14:30 ` Ilpo Järvinen
2026-10-09  7:24 ` [PATCH v2] " chitranshmandhaniya
2026-10-09 10:48   ` Ilpo Järvinen
2026-10-09 12:26   ` [PATCH v3 0/2] " chitranshmandhaniya
2026-10-09 12:26     ` [PATCH v3 1/2] platform/x86: dell-uart-backlight: extract dell_uart_bl_init() from probe chitranshmandhaniya
2026-10-09 12:26     ` [PATCH v3 2/2] platform/x86: dell-uart-backlight: fall back to PCH PWM on UART timeout chitranshmandhaniya
2026-10-09 23:46   ` [PATCH v2] " kernel test robot
2026-10-10 10:20   ` [PATCH v4 0/2] " chitranshmandhaniya
2026-10-10 10:20     ` [PATCH v4 1/2] platform/x86: dell-uart-backlight: extract dell_uart_bl_init() from probe chitranshmandhaniya
2026-10-10 10:20     ` [PATCH v4 2/2] platform/x86: dell-uart-backlight: fall back to PCH PWM on UART timeout chitranshmandhaniya
2026-10-10 11:41     ` [PATCH v4 0/2] " Hans de Goede
2026-10-10 12:48   ` [PATCH v5] ACPI: video: force native backlight on Dell OptiPlex AIO 7410 35W chitranshmandhaniya
2026-10-12 14:54     ` Hans de Goede [this message]
2026-10-12 18:11       ` Rafael J. Wysocki (Intel)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96f4dc4d-eb5c-4af2-86e4-8d10f87b3d9d@kernel.org \
    --to=hansg@kernel.org \
    --cc=Chitransh_Mandhaniya@dell.com \
    --cc=chitranshmandhaniya@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.