From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
Pankaj Raghav <p.raghav@samsung.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"gost.dev@samsung.com" <gost.dev@samsung.com>,
Pankaj Raghav <pankydev8@gmail.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free]
Date: Wed, 30 Nov 2022 23:21:30 +0000 [thread overview]
Message-ID: <96fc644e-e5f2-7dae-f81d-fa970c0f8bc7@nvidia.com> (raw)
In-Reply-To: <Y4fCS2d2r1YvSExI@fedora>
On 11/30/22 12:51, Stefan Hajnoczi wrote:
> On Wed, Nov 30, 2022 at 01:30:03PM +0100, Pankaj Raghav wrote:
>> ida_simple[get|remove] are deprecated, and are just wrappers to
>> ida_[alloc_range|free]. Replace ida_simple[get|remove] with their
>> corresponding counterparts.
>>
>> No functional changes.
>>
>> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
>> ---
>> drivers/block/virtio_blk.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Chaitanya proposed a similar patch in the past:
> https://lore.kernel.org/all/20220420041053.7927-5-kch@nvidia.com/
>
> Your patch calculates the max argument correctly. Looks good.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Ughhh I completely forgot about this, thanks a lot for fixing
this Pankaj.
-ck
next prev parent reply other threads:[~2022-11-30 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221130123126eucas1p2cd3287ee4e5c03642f1847c50af0e4f2@eucas1p2.samsung.com>
2022-11-30 12:30 ` [PATCH] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free] Pankaj Raghav
2022-11-30 20:51 ` Stefan Hajnoczi
2022-11-30 20:51 ` Stefan Hajnoczi
2022-11-30 23:21 ` Chaitanya Kulkarni [this message]
2022-11-30 21:24 ` Jens Axboe
2022-11-30 21:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96fc644e-e5f2-7dae-f81d-fa970c0f8bc7@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.