All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH] dev: don't fail the hotplug request if device is attached in secondary
Date: Sun, 25 Nov 2018 13:28:50 +0100	[thread overview]
Message-ID: <9706776.xTluRg8pfR@xps> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611532EA1B2@SHSMSX103.ccr.corp.intel.com>

> > Consider the following scenario:
> > 
> >  1) primary process (A) starts, probes the bus
> >  2) a secondary process (B) starts, probes the bus
> >  3) yet another secondary process (C) starts
> >  4) (C) registers the pci driver and hotplugs the device
> >     * an IPC attach req is sent to the primary (A)
> >       * (A) ignores the -EEXIST from process-local probe
> >       * (A) propagates the request to all secondary processes
> >         * (B) responds with -EEXIST
> >       * (A) replies to the original request with the -EEXIST
> >         return code
> >     * the -EEXIST is returned back to the user, although the
> >       device was successfully attached both locally and in
> >       all other processes
> > 
> > This patch makes the primary process reply with rc=0 even if there was another
> > secondary process with the device already attached. The primary process
> > already didn't reply with -EEXIST when the device was attached locally, so now
> > this behavior is even more consistent. Looking by the code, this seems to be the
> > originally intended behavior.
> > 
> > Fixes: ac9e4a17370f ("eal: support attach/detach shared device from
> > secondary")
> > Cc: qi.z.zhang@intel.com
> > 
> > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied, thanks

      reply	other threads:[~2018-11-25 12:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23 14:58 [PATCH] dev: don't fail the hotplug request if device is attached in secondary Darek Stojaczyk
2018-11-23 18:30 ` Zhang, Qi Z
2018-11-25 12:28   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9706776.xTluRg8pfR@xps \
    --to=thomas@monjalon.net \
    --cc=dariusz.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.