All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Erik Jacobson <erikj@subway.americas.sgi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.6 /proc/interrupts fails on systems with many CPUs
Date: Tue, 11 Nov 2003 10:02:03 -0800	[thread overview]
Message-ID: <9710000.1068573723@flay> (raw)
In-Reply-To: <Pine.SGI.4.53.0311111116440.360387@subway.americas.sgi.com>

> On systems with lots of processors (512 for example), catting /proc/interrupts
> fails with a "not enough memory" error.
> 
> This was observed in 2.6.0-test8
> 
> I tracked this down to this in proc_misc.c:
> 
> static int interrupts_open(struct inode *inode, struct file *file)
> {
>    unsigned size = 4096 * (1 + num_online_cpus() / 8);
>    char *buf = kmalloc(size, GFP_KERNEL);
> 
> The kmalloc fails here.
> 
> I'm looking for suggestions on how to fix this.  I came up with one fix
> that seems to work OK for ia64.  I have attached it to this message.
> I'm looking for advice on what should be proposed for the real fix.

I think it'd make more sense to only use vmalloc when it's explicitly 
too big for kmalloc - or simply switch on num_online_cpus > 100 or 
whatever a sensible cutoff is (ie nobody but you would ever see this ;-))

M.


  parent reply	other threads:[~2003-11-11 17:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-11 17:21 2.6 /proc/interrupts fails on systems with many CPUs Erik Jacobson
2003-11-11 17:29 ` Randy.Dunlap
2003-11-11 17:51 ` Robert Love
2003-11-11 18:02 ` Martin J. Bligh [this message]
2003-11-11 18:24   ` Linus Torvalds
2003-11-11 18:57     ` Martin J. Bligh
2003-11-11 18:36       ` Linus Torvalds
2003-11-11 20:14     ` Anton Blanchard
2003-11-11 22:41       ` Martin J. Bligh
2003-11-11 22:32         ` Zwane Mwaikambo
2004-01-27  4:12     ` radeonfb problems with 2.6.2-rc2 Roland Dreier
2003-11-11 18:17 ` 2.6 /proc/interrupts fails on systems with many CPUs Linus Torvalds
2003-11-11 18:22   ` viro
2003-11-11 20:15     ` Jonathan Corbet
2003-11-11 18:32   ` Randy.Dunlap
2003-11-11 19:19 ` Anton Blanchard
  -- strict thread matches above, loose matches on Subject: below --
2003-11-11 18:15 Manfred Spraul
     [not found] <BF1FE1855350A0479097B3A0D2A80EE0013B1188@hdsmsx402.hd.intel.com>
2003-11-11 19:55 ` Len Brown
2003-11-11 23:37   ` Erlend Aasland
2003-11-12  2:35     ` Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9710000.1068573723@flay \
    --to=mbligh@aracnet.com \
    --cc=erikj@subway.americas.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.