From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation Date: Mon, 10 Dec 2018 09:50:08 +0200 Message-ID: <9717353.uOtl8oZA8J@avalon> References: <20181205150022.24200-1-laurent.pinchart@ideasonboard.com> <20181205150022.24200-23-laurent.pinchart@ideasonboard.com> <20181209220755.y4leg6ud233hsrmf@earth.universe> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1E6C6E30C for ; Mon, 10 Dec 2018 07:49:30 +0000 (UTC) In-Reply-To: <20181209220755.y4leg6ud233hsrmf@earth.universe> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sebastian Reichel Cc: Tomi Valkeinen , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2ViYXN0aWFuLAoKT24gTW9uZGF5LCAxMCBEZWNlbWJlciAyMDE4IDAwOjA3OjU1IEVFVCBT ZWJhc3RpYW4gUmVpY2hlbCB3cm90ZToKPiBPbiBXZWQsIERlYyAwNSwgMjAxOCBhdCAwNTowMDox NVBNICswMjAwLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gVGhlIERJU1BDIHRpbWluZ3Mg Y2hlY2tzIHJlbGF0ZSB0byB0aGUgQ1JUQywgYnV0IHRoZXkncmUgcGVyZm9ybWVkIGluCj4gPiB0 aGUgZW5jb2RlciBhbmQgY29ubmVjdG9yIC5hdG9taWNfY2hlY2soKSBhbmQgLm1vZGVfdmFsaWQo KSBvcGVyYXRpb25zLgo+ID4gTW92ZSB0aGVtIHRvIHRoZSBDUlRDIC5tb2RlX3ZhbGlkKCkgb3Bl cmF0aW9uLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50 LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiAtLS0KPiAKPiBSZXZpZXdlZC1ieTogU2Vi YXN0aWFuIFJlaWNoZWwgPHNlYmFzdGlhbi5yZWljaGVsQGNvbGxhYm9yYS5jb20+Cj4gCj4gVGhp cyBzaG91bGQgYWxzbyBmaXggdGhlIGlzc3VlIHdpdGggRFNJIGluIGEgbGVzcyB1Z2x5IHdheToK PiAKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAx OC1Ob3ZlbWJlci8xOTY2MjIuaHRtbAoKU2hvdWxkIEkgYWRkIHRoZQoKRml4ZXM6IDdjMjdmYTU3 ZWYzMSAoImRybS9vbWFwOiBDYWxsIGRpc3BjIHRpbWluZ3MgY2hlY2sgb3BlcmF0aW9uIGRpcmVj dGx5IikKCnRhZyB0byB0aGlzIHBhdGNoID8KCj4gPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9jb25uZWN0b3IuYyB8IDYgLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9jcnRjLmMgICAgICB8IDkgKysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL29tYXBk cm0vb21hcF9lbmNvZGVyLmMgICB8IDYgLS0tLS0tCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA5IGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9jb25uZWN0b3IuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0v b21hcGRybS9vbWFwX2Nvbm5lY3Rvci5jIGluZGV4Cj4gPiA4ZGIxZjJmYmNmNDMuLmRkMWUwZjJl OGZmYyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY29ubmVj dG9yLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY29ubmVjdG9yLmMK PiA+IEBAIC0yNDUsOCArMjQ1LDYgQEAgc3RhdGljIGludCBvbWFwX2Nvbm5lY3Rvcl9tb2RlX3Zh bGlkKHN0cnVjdAo+ID4gZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLD4gCj4gPiAgCQkJCSBzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkKPiA+ICAKPiA+ICB7Cj4gPiAgCj4gPiAgCXN0cnVj dCBvbWFwX2Nvbm5lY3RvciAqb21hcF9jb25uZWN0b3IgPSB0b19vbWFwX2Nvbm5lY3Rvcihjb25u ZWN0b3IpOwo+ID4gCj4gPiAtCWVudW0gb21hcF9jaGFubmVsIGNoYW5uZWwgPSBvbWFwX2Nvbm5l Y3Rvci0+b3V0cHV0LT5kaXNwY19jaGFubmVsOwo+ID4gLQlzdHJ1Y3Qgb21hcF9kcm1fcHJpdmF0 ZSAqcHJpdiA9IGNvbm5lY3Rvci0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IAo+ID4gIAlzdHJ1Y3Qg b21hcF9kc3NfZGV2aWNlICpkc3NkZXY7Cj4gPiAgCXN0cnVjdCB2aWRlb21vZGUgdm0gPSB7MH07 Cj4gPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjb25uZWN0b3ItPmRldjsKPiA+IAo+ID4g QEAgLTI1NiwxMCArMjU0LDYgQEAgc3RhdGljIGludCBvbWFwX2Nvbm5lY3Rvcl9tb2RlX3ZhbGlk KHN0cnVjdAo+ID4gZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLD4gCj4gPiAgCWRybV9kaXNwbGF5 X21vZGVfdG9fdmlkZW9tb2RlKG1vZGUsICZ2bSk7Cj4gPiAgCW1vZGUtPnZyZWZyZXNoID0gZHJt X21vZGVfdnJlZnJlc2gobW9kZSk7Cj4gPiAKPiA+IC0JciA9IHByaXYtPmRpc3BjX29wcy0+bWdy X2NoZWNrX3RpbWluZ3MocHJpdi0+ZGlzcGMsIGNoYW5uZWwsICZ2bSk7Cj4gPiAtCWlmIChyKQo+ ID4gLQkJZ290byBkb25lOwo+ID4gLQo+ID4gCj4gPiAgCWZvciAoZHNzZGV2ID0gb21hcF9jb25u ZWN0b3ItPm91dHB1dDsgZHNzZGV2OyBkc3NkZXYgPSBkc3NkZXYtPm5leHQpIHsKPiA+ICAJCj4g PiAgCQlpZiAoIWRzc2Rldi0+b3BzLT5jaGVja190aW1pbmdzKQo+ID4gIAkJCj4gPiAgCQkJY29u dGludWU7Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFw X2NydGMuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2NydGMuYyBpbmRleCBj YWZmYzU0N2VmOTcuLjUxMDM2ZTZmY2ExYwo+ID4gMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vb21hcGRybS9vbWFwX2NydGMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL29tYXBk cm0vb21hcF9jcnRjLmMKPiA+IEBAIC0zOTEsNiArMzkxLDE1IEBAIHN0YXRpYyBlbnVtIGRybV9t b2RlX3N0YXR1cwo+ID4gb21hcF9jcnRjX21vZGVfdmFsaWQoc3RydWN0IGRybV9jcnRjICpjcnRj LD4gCj4gPiAgCQkJCQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkKPiA+ICAK PiA+ICB7Cj4gPiAgCj4gPiAgCXN0cnVjdCBvbWFwX2RybV9wcml2YXRlICpwcml2ID0gY3J0Yy0+ ZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IAo+ID4gKwlzdHJ1Y3Qgb21hcF9jcnRjICpvbWFwX2NydGMg PSB0b19vbWFwX2NydGMoY3J0Yyk7Cj4gPiArCXN0cnVjdCB2aWRlb21vZGUgdm0gPSB7MH07Cj4g PiArCWludCByOwo+ID4gKwo+ID4gKwlkcm1fZGlzcGxheV9tb2RlX3RvX3ZpZGVvbW9kZShtb2Rl LCAmdm0pOwo+ID4gKwlyID0gcHJpdi0+ZGlzcGNfb3BzLT5tZ3JfY2hlY2tfdGltaW5ncyhwcml2 LT5kaXNwYywgb21hcF9jcnRjLT5jaGFubmVsLAo+ID4gKwkJCQkJICAgICAgICZ2bSk7Cj4gPiAr CWlmIChyKQo+ID4gKwkJcmV0dXJuIHI7Cj4gPiAKPiA+ICAJLyogQ2hlY2sgZm9yIGJhbmR3aWR0 aCBsaW1pdCAqLwo+ID4gIAlpZiAocHJpdi0+bWF4X2JhbmR3aWR0aCkgewo+ID4gCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9lbmNvZGVyLmMKPiA+IGIvZHJp dmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9lbmNvZGVyLmMgaW5kZXggNzllZTkyN2NkOTA1Li43 ZDAxZGY2ZmE3MjMKPiA+IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v b21hcF9lbmNvZGVyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZW5j b2Rlci5jCj4gPiBAQCAtMTk4LDE5ICsxOTgsMTMgQEAgc3RhdGljIGludCBvbWFwX2VuY29kZXJf YXRvbWljX2NoZWNrKHN0cnVjdAo+ID4gZHJtX2VuY29kZXIgKmVuY29kZXIsPiAKPiA+ICAJCQkJ ICAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSkKPiA+ICAKPiA+ICB7 Cj4gPiAgCj4gPiAgCXN0cnVjdCBvbWFwX2VuY29kZXIgKm9tYXBfZW5jb2RlciA9IHRvX29tYXBf ZW5jb2RlcihlbmNvZGVyKTsKPiA+IAo+ID4gLQllbnVtIG9tYXBfY2hhbm5lbCBjaGFubmVsID0g b21hcF9lbmNvZGVyLT5vdXRwdXQtPmRpc3BjX2NoYW5uZWw7Cj4gPiAKPiA+ICAJc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9IGVuY29kZXItPmRldjsKPiA+IAo+ID4gLQlzdHJ1Y3Qgb21hcF9kcm1f cHJpdmF0ZSAqcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiAKPiA+ICAJc3RydWN0IG9tYXBf ZHNzX2RldmljZSAqZHNzZGV2Owo+ID4gIAlzdHJ1Y3QgdmlkZW9tb2RlIHZtID0geyAwIH07Cj4g PiAgCWludCByZXQ7Cj4gPiAgCQo+ID4gIAlkcm1fZGlzcGxheV9tb2RlX3RvX3ZpZGVvbW9kZSgm Y3J0Y19zdGF0ZS0+bW9kZSwgJnZtKTsKPiA+IAo+ID4gLQlyZXQgPSBwcml2LT5kaXNwY19vcHMt Pm1ncl9jaGVja190aW1pbmdzKHByaXYtPmRpc3BjLCBjaGFubmVsLCAmdm0pOwo+ID4gLQlpZiAo cmV0KQo+ID4gLQkJZ290byBkb25lOwo+ID4gLQo+ID4gCj4gPiAgCWZvciAoZHNzZGV2ID0gb21h cF9lbmNvZGVyLT5vdXRwdXQ7IGRzc2RldjsgZHNzZGV2ID0gZHNzZGV2LT5uZXh0KSB7Cj4gPiAg CQo+ID4gIAkJaWYgKCFkc3NkZXYtPm9wcy0+Y2hlY2tfdGltaW5ncykKPiA+ICAJCQo+ID4gIAkJ CWNvbnRpbnVlOwoKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK