Re: [PATCH v2 5/6] PCI: endpoint: cleanup get_msix() callback

[Damien Le Moal <dlemoal@kernel.org>]

On 5/13/25 16:31, Niklas Cassel wrote:
> The kdoc for pci_epc_get_msix() says:
> "Invoke to get the number of MSI-X interrupts allocated by the RC"
> the kdoc for the callback pci_epc_ops->get_msix() says:
> "ops to get the number of MSI-X interrupts allocated by the RC from the
> MSI-X capability register"
> 
> pci_epc_ops->get_msix() does however return the number of interrupts
> in the encoding as defined by the Table Size field.
> 
> Nowhere in the kdoc does it say that the returned number of interrupts
> is in Table Size encoding.
> 
> Thus, it is very confusing that the wrapper function (pci_epc_get_msix())
> and the callback function (pci_epc_ops->get_msix()) don't return the same
> value.
> 
> Cleanup the API so that the wrapper function and the callback function
> will have the same semantics.

Same comment as previous patches. Mention the semantic.

But looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research