From: Markus Elfring <Markus.Elfring@web.de>
To: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"MD Danish Anwar" <danishanwar@ti.com>,
"Michael Grzeschik" <mgr@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
"Yibo Dong" <dong100@mucse.com>,
LKML <linux-kernel@vger.kernel.org>,
"Dan Carpenter" <error27@gmail.com>
Subject: Re: [v2 net-next] net: rnpgbe: Delete a null pointer check in rnpgbe_rm_adapter()
Date: Fri, 17 Jul 2026 08:10:01 +0200 [thread overview]
Message-ID: <97451fd1-3d52-4e07-a1ed-634eaef53481@web.de> (raw)
In-Reply-To: <2d60fe2b-06cf-4c35-98a0-fc0f8034180b@lunn.ch>
>> The check for the pointer “mucse” was finally identified as undesirable.
> I'm not sure finally is appropriate. It was one of the first questions
> i asked. Also, i expect anybody looking at a Coccinelle report to take
> the time to understand the code and decide what the correct fix is. We
> have too many developers doing the minimum to make the tool happy,
> without actually thinking.
>
> Please also include the reasoning behind this. The commit message is
> all about "Why?" Why is it undesirable?
Why could a redundant sanity check be tolerated for a while?
Regards,
Markus
next prev parent reply other threads:[~2026-07-17 6:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 18:35 [PATCH net] net: rnpgbe: Pass an expression directly in rnpgbe_rm_adapter() Markus Elfring
2026-07-12 22:19 ` Vadim Fedorenko
2026-07-13 6:00 ` Markus Elfring
2026-07-13 8:04 ` [PATCH net] " Dan Carpenter
2026-07-13 8:22 ` Markus Elfring
2026-07-15 13:12 ` Uwe Kleine-König
2026-07-15 18:45 ` Markus Elfring
2026-07-16 9:30 ` Dan Carpenter
2026-07-16 9:48 ` Markus Elfring
2026-07-16 13:24 ` Andrew Lunn
2026-07-16 13:34 ` Dan Carpenter
2026-07-16 13:43 ` Andrew Lunn
2026-07-16 17:26 ` [PATCH v2 net-next] net: rnpgbe: Delete a null pointer check " Markus Elfring
2026-07-16 19:40 ` Andrew Lunn
2026-07-17 6:10 ` Markus Elfring [this message]
2026-07-16 6:57 ` [PATCH net] net: rnpgbe: Pass an expression directly " Dan Carpenter
2026-07-16 8:20 ` Markus Elfring
2026-07-16 13:30 ` Dan Carpenter
2026-07-16 16:19 ` Markus Elfring
2026-07-16 14:27 ` Jonathan Corbet
2026-07-16 16:30 ` Markus Elfring
2026-07-14 22:20 ` [PATCH net] " Andrew Lunn
2026-07-15 5:22 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97451fd1-3d52-4e07-a1ed-634eaef53481@web.de \
--to=markus.elfring@web.de \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgr@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.