From: "David D. Kilzer" <ddkilzer@kilzer.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Intermittent failures in t9119
Date: Sat, 4 Dec 2010 17:21:38 -0800 (PST) [thread overview]
Message-ID: <97465.53475.qm@web30008.mail.mud.yahoo.com> (raw)
In-Reply-To: <7vmxoml1p7.fsf@alter.siamese.dyndns.org>
On Fri, December 3, 2010 at 6:19:16 PM, Junio C Hamano wrote:
> I am seeing breakages from the said test:
>
> not ok - 6 info file
> #
> # (cd svnwc; svn info file) > expected.info-file &&
> # (cd gitwc; git svn info file) > actual.info-file &&
> # test_cmp expected.info-file actual.info-file
>
> : trash directory.t9119-git-svn-info/master; diff *.info-file
> 12c12
> < Text Last Updated: 2010-12-04 00:34:58 +0000 (Sat, 04 Dec 2010)
> ---
> > Text Last Updated: 2010-12-04 00:34:57 +0000 (Sat, 04 Dec 2010)
>
> I do not know if we should expect output from "svn info" to match exactly
> like the above. Is "Text Last Updated" supposed to show the stat
> timestamp of the working tree (I see "(stat $path)[9]" there)? If so,
> unless the checkout/update in svnwc and gitwc prior to this test was done
> within the same second, we do not have a good reason to expect that these
> files should be identical.
The modification timestamp (mtime) for the two files should be in sync due to
this line in t9119-git-svn-info.sh in 'setup repository and import':
ptouch gitwc/file svnwc/file &&
> I _think_ "svn info file" actually gives the timestamp of the revision
> that touched the file the last (in their linear worldview of the history),
> so perhaps this is demonstrating the real bug, but only when the test runs
> very slowly?
What platform/OS is the test failing on? I can't reproduce it on an 8-core Mac
Pro with Mac OS X 10.6.5.
Dave
next prev parent reply other threads:[~2010-12-05 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-04 2:19 Intermittent failures in t9119 Junio C Hamano
2010-12-05 1:21 ` David D. Kilzer [this message]
2010-12-05 4:50 ` Junio C Hamano
2010-12-05 20:39 ` Junio C Hamano
2010-12-06 19:10 ` Eric Wong
2010-12-07 0:00 ` Junio C Hamano
2010-12-09 17:55 ` Eric Wong
2010-12-31 14:13 ` David D. Kilzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97465.53475.qm@web30008.mail.mud.yahoo.com \
--to=ddkilzer@kilzer.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.