From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROsoN-0005UF-0k for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:14:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROsoI-0000Zo-8f for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:14:34 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]:36931) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ROsoH-0000Zf-Ss for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:14:30 -0500 Date: Fri, 11 Nov 2011 16:14:24 +0100 From: "Thomas Schmitt" References: <4EBD2564.6080105@redhat.com> In-Reply-To: <4EBD2564.6080105@redhat.com> Message-Id: <974655724411@192.168.2.69> Subject: [Qemu-devel] Re: [PATCH 1/5] atapi: kill MODE SENSE(6), fix MODE SENSE(10) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, kraxel@redhat.com Hi, Paolo Bonzini wrote: > > > case MODE_PAGE_R_W_ERROR: /* error recovery */ > > > [...] > > > - buf[15] = 0x00; Kevin Wolf wrote: > > Why did you drop this? It still seems to be part of the buffer. Paolo Bonzini wrote: > Actually, I think it's best if these patches wait until Thomas can give a > shot at testing them. If that means missing 1.0, so be it. libburn does not use mode page 1 "Read/Write Error Recovery Parameters". So can only judge by theory and not by test. MMC-1 says it has 8 bytes (beginning at buf[8] = MODE_PAGE_R_W_ERROR). MMC-2 says it has 12. MMC-6 says it has 12. So buf[15] = 0x00 matches MMC-1 and the announcement made by buf[9] = 16 - 10; (6 is the number of bytes after buf[9]). I would advise to keep buf[15] = 0x00. Have a nice day :) Thomas