From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Pitoiset Subject: Re: [PATCH 1/2] drm/amdgpu: drop multiple bo_unreserve() calls in amdgpu_gem_op_ioctl() Date: Fri, 10 Feb 2017 12:09:10 +0100 Message-ID: <975f00cf-0c37-97ed-48cf-3d11e62d50c8@gmail.com> References: <20170209222824.3267-1-samuel.pitoiset@gmail.com> <589D2B9C.309@amd.com> <0c47615f-6e93-eea1-418c-f846a0c1d3ae@gmail.com> <185ea16c-7062-f137-2234-a19f845062a6@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <185ea16c-7062-f137-2234-a19f845062a6-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , zhoucm1 , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAwMi8xMC8yMDE3IDExOjM3IEFNLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+IEFtIDEw LjAyLjIwMTcgdW0gMTE6MjIgc2NocmllYiBTYW11ZWwgUGl0b2lzZXQ6Cj4+Cj4+Cj4+IE9uIDAy LzEwLzIwMTcgMTE6MTkgQU0sIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4+PiBBbSAxMC4wMi4y MDE3IHVtIDExOjExIHNjaHJpZWIgU2FtdWVsIFBpdG9pc2V0Ogo+Pj4+Cj4+Pj4KPj4+PiBPbiAw Mi8xMC8yMDE3IDAzOjU1IEFNLCB6aG91Y20xIHdyb3RlOgo+Pj4+Pgo+Pj4+Pgo+Pj4+PiBPbiAy MDE35bm0MDLmnIgxMOaXpSAwNjoyOCwgU2FtdWVsIFBpdG9pc2V0IHdyb3RlOgo+Pj4+Pj4gTW92 ZSBhbWRncHVfYm9fdW5yZXNlcnZlKCkgb3V0c2lkZSBvZiB0aGUgc3dpdGNoLiBXaGlsZSB3ZSBh cmUKPj4+Pj4+IGF0IGl0LCBhZGQgYSBtaXNzaW5nIGJyZWFrIGluIHRoZSBkZWZhdWx0IGNhc2Uu Cj4+Pj4+Pgo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogU2FtdWVsIFBpdG9pc2V0IDxzYW11ZWwucGl0 b2lzZXRAZ21haWwuY29tPgo+Pj4+Pj4gLS0tCj4+Pj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9nZW0uYyB8IDcgKystLS0tLQo+Pj4+Pj4gICAxIGZpbGUgY2hhbmdlZCwg MiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Pj4+Pj4KPj4+Pj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMKPj4+Pj4+IGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jCj4+Pj4+PiBpbmRleCAxZGM1OWFhZmVj NzEuLmFlNDY1OGExMGUyYyAxMDA2NDQKPj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9nZW0uYwo+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2dlbS5jCj4+Pj4+PiBAQCAtNjYwLDcgKzY2MCw2IEBAIGludCBhbWRncHVfZ2Vt X29wX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4+PiB2b2lkICpkYXRhLAo+Pj4+ Pj4gICAgICAgICAgIGluZm8uYWxpZ25tZW50ID0gcm9iai0+dGJvLm1lbS5wYWdlX2FsaWdubWVu dCA8PAo+Pj4+Pj4gUEFHRV9TSElGVDsKPj4+Pj4+ICAgICAgICAgICBpbmZvLmRvbWFpbnMgPSBy b2JqLT5wcmVmZXJlZF9kb21haW5zOwo+Pj4+Pj4gICAgICAgICAgIGluZm8uZG9tYWluX2ZsYWdz ID0gcm9iai0+ZmxhZ3M7Cj4+Pj4+PiAtICAgICAgICBhbWRncHVfYm9fdW5yZXNlcnZlKHJvYmop Owo+Pj4+Pj4gICAgICAgICAgIGlmIChjb3B5X3RvX3VzZXIob3V0LCAmaW5mbywgc2l6ZW9mKGlu Zm8pKSkKPj4+Pj4+ICAgICAgICAgICAgICAgciA9IC1FRkFVTFQ7Cj4+Pj4+IE5BSywgeW91ciB0 aGlzIGNoYW5nZSB3aWxsIGJyZWFrIG91ciBwcmV2aW91cyBkZWFkbG9jayBmaXggZm9yCj4+Pj4+ IHd3X211dGV4Cj4+Pj4+IGFuZCBtbS0+bW1hcF9zZW0gaWYgSSByZW1lbWJlciBjb3JyZWN0bHku Cj4+Pj4KPj4+PiBNbWgsIHJlYWxseT8gQ2FuIHlvdSBwaW5wb2ludCB0aGUgY29tbWl0PyBJIGRv bid0IHNlZSBhbnl0aGluZyBvYnZpb3VzCj4+Pj4gaW4gdGhlIGhpc3RvcnkgYWJvdXQgdGhhdC4K Pj4+Cj4+PiBEYXZpZCBpcyByaWdodCBoZXJlLiBOb3Qgc3VyZSB3aGVuIHdlIGZpeGVkIHRoYXQs IGJ1dCBpbiBnZW5lcmFsIGNhbGxpbmcKPj4+IGNvcHlfdG8vZnJvbV91c2VyIHdoaWxlIGEgQk8g aXMgcmVzZXJ2ZWQgaXMgaWxsZWdhbC4KPj4+Cj4+PiBPdGhlcndpc2Ugc29tZWJvZHkgY291bGQg c2VuZCB0aGUga2VybmVsIGEgbWVtb3J5IG1hcHBlZCBCTyBhcyBhZGRyZXNzCj4+PiBhbmQgdGhl IGNvcHlfdG8vZnJvbV91c2VyIHdvdWxkIGp1c3QgZGVhZGxvY2sgYmVjYXVzZSBpdCB0cmllcyB0 bwo+Pj4gcmVzZXJ2ZSBhIEJPIHdoaWxlIGFub3RoZXIgKG9yIHRoZSBzYW1lKSBCTyBpcyBhbHJl YWR5IHJlc2VydmVkIGluIHRoZQo+Pj4gY2FsbCBwYXRoLgo+Pgo+PiBPa2F5LCBtYWtlcyBtb3Jl IHNlbnNlLgo+Pgo+PiBUaGFua3MgZm9yIHRoZSByZXZpZXcuIE15IGdvYWwgaXMgbm90IHRvIGlu dHJvZHVjZSBuZXcgcmVncmVzc2lvbnMgYnV0Cj4+IEkgZGlkbid0IGtub3cgdGhhdC4KPj4KPj4g TWF5YmUgdGhpcyBzaG91bGQgYmUgZXhwbGFpbmVkIGluIHRoZSBjb2RlPyBKdXN0IGEgdGhvdWdo dC4KPgo+IFdlIGRvIGhhdmUgYSBjb21tZW50IGluIHRoZSBUVE0gbWFwcGluZyBjb2RlIEkgdGhp bmsuCj4KPiBCdXQgY29weV90by9mcm9tX3VzZXIgYW5kIEJPIHJlc2VydmF0aW9uIGlzIGp1c3Qg c28gY29tbW9uIHRoYXQgd2Ugd291bGQKPiBuZWVkIHRvIGFkZCB0aGUgc2FtZSBjb21tZW50IG9u IGEgd2hvbGUgYnVuY2ggb2YgZGlmZmVyZW50IHBsYWNlcyBhbmQKPiB0aGF0IGRvZXNuJ3QgbWFr ZSB0byBtdWNoIHNlbnNlLgo+Cj4gQnV0IGluIHRoaXMgcGFydGljdWxhciBjYXNlIGEgY29tbWVu dCBtaWdodCBtYWtlIHNlbnNlIGJlY2F1c2UgSSB0aGluawo+IHNvbWVib2R5IHByb3Bvc2VkIHRo ZSBzYW1lIHBhdGNoIGJlZm9yZS4gQWghIEVubGlnaHRlbm1lbnQsIHRoYXQgYWxzbwo+IGV4cGxh aW5zIHdoeSB5b3UgY2FuJ3QgZmluZCBpdCBpbiB0aGUgaGlzdG9yeS4gV2UganVzdCByZWplY3Rl ZCB0aGUgc2FtZQo+IHBhdGNoIG11bHRpcGxlIHRpbWVzIG5vdyA6KQoKWWVhaCwgSSBiZXQgc29t ZW9uZSBlbHNlIHdpbGwgc3VibWl0IHRoZSBzYW1lIHBhdGNoIGluIGZldyB3ZWVrcy9tb250aHMg CndpdGhvdXQgYSBjb21tZW50IGV4cGxhaW5pbmcgd2h5IHdlIHNob3VsZG4ndCBjaGFuZ2UgaXQu IDopCgo+Cj4gUmVnYXJkcywKPiBDaHJpc3RpYW4uCj4KPj4KPj4+Cj4+PiBSZWdhcmRzLAo+Pj4g Q2hyaXN0aWFuLgo+Pj4KPj4+Pgo+Pj4+IFRoYW5rcy4KPj4+Pgo+Pj4+Pgo+Pj4+PiBSZWdhcmRz LAo+Pj4+PiBEYXZpZCBaaG91Cj4+Pj4+PiAgICAgICAgICAgYnJlYWs7Cj4+Pj4+PiBAQCAtNjY4 LDcgKzY2Nyw2IEBAIGludCBhbWRncHVfZ2VtX29wX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsCj4+Pj4+PiB2b2lkICpkYXRhLAo+Pj4+Pj4gICAgICAgY2FzZSBBTURHUFVfR0VNX09QX1NF VF9QTEFDRU1FTlQ6Cj4+Pj4+PiAgICAgICAgICAgaWYgKGFtZGdwdV90dG1fdHRfZ2V0X3VzZXJt bShyb2JqLT50Ym8udHRtKSkgewo+Pj4+Pj4gICAgICAgICAgICAgICByID0gLUVQRVJNOwo+Pj4+ Pj4gLSAgICAgICAgICAgIGFtZGdwdV9ib191bnJlc2VydmUocm9iaik7Cj4+Pj4+PiAgICAgICAg ICAgICAgIGJyZWFrOwo+Pj4+Pj4gICAgICAgICAgIH0KPj4+Pj4+ICAgICAgICAgICByb2JqLT5w cmVmZXJlZF9kb21haW5zID0gYXJncy0+dmFsdWUgJgo+Pj4+Pj4gKEFNREdQVV9HRU1fRE9NQUlO X1ZSQU0gfAo+Pj4+Pj4gQEAgLTY3NywxNCArNjc1LDEzIEBAIGludCBhbWRncHVfZ2VtX29wX2lv Y3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4+PiB2b2lkICpkYXRhLAo+Pj4+Pj4gICAg ICAgICAgIHJvYmotPmFsbG93ZWRfZG9tYWlucyA9IHJvYmotPnByZWZlcmVkX2RvbWFpbnM7Cj4+ Pj4+PiAgICAgICAgICAgaWYgKHJvYmotPmFsbG93ZWRfZG9tYWlucyA9PSBBTURHUFVfR0VNX0RP TUFJTl9WUkFNKQo+Pj4+Pj4gICAgICAgICAgICAgICByb2JqLT5hbGxvd2VkX2RvbWFpbnMgfD0g QU1ER1BVX0dFTV9ET01BSU5fR1RUOwo+Pj4+Pj4gLQo+Pj4+Pj4gLSAgICAgICAgYW1kZ3B1X2Jv X3VucmVzZXJ2ZShyb2JqKTsKPj4+Pj4+ICAgICAgICAgICBicmVhazsKPj4+Pj4+ICAgICAgIGRl ZmF1bHQ6Cj4+Pj4+PiAtICAgICAgICBhbWRncHVfYm9fdW5yZXNlcnZlKHJvYmopOwo+Pj4+Pj4g ICAgICAgICAgIHIgPSAtRUlOVkFMOwo+Pj4+Pj4gKyAgICAgICAgYnJlYWs7Cj4+Pj4+PiAgICAg ICB9Cj4+Pj4+PiAgICsgICAgYW1kZ3B1X2JvX3VucmVzZXJ2ZShyb2JqKTsKPj4+Pj4+ICAgb3V0 Ogo+Pj4+Pj4gICAgICAgZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2VfdW5sb2NrZWQoZ29iaik7 Cj4+Pj4+PiAgICAgICByZXR1cm4gcjsKPj4+Pj4KPj4+PiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+Pj4+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4+Pj4g YW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4+PiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKPj4+Cj4+Pgo+PiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBhbWQtZ2Z4IG1haWxpbmcgbGlz dAo+PiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKPgo+Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=