All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: linux-rockchip@lists.infradead.org, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator
Date: Fri, 21 Apr 2023 13:48:23 +0200	[thread overview]
Message-ID: <9785919.DvuYhMxLoT@phil> (raw)
In-Reply-To: <20230420101555.2980-1-naoki@radxa.com>

Hi,

Am Donnerstag, 20. April 2023, 12:15:55 CEST schrieb FUKAUMI Naoki:
> "gpios" should be "gpio"

I don't see this.

The fixed-regulator binding does specify both "gpios" and "gpio" as valid.
And the code also tries both [0].

So this change really isn't necessary.


Heiko

[0] https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.h#L86

> Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> index 63c4bd873188..bde43c4a5bb1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> @@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
>  	vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
>  		compatible = "regulator-fixed";
>  		enable-active-high;
> -		gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
> +		gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pcie_enable_h>;
>  		regulator-name = "vcc3v3_pcie";
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2023-04-21 11:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20 10:15 [PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator FUKAUMI Naoki
2023-04-21 11:48 ` Heiko Stuebner [this message]
2023-04-21 23:14   ` FUKAUMI Naoki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9785919.DvuYhMxLoT@phil \
    --to=heiko@sntech.de \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=naoki@radxa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.