Re: [PATCH net-next] net: constify net_class

[Heiner Kallweit <hkallweit1@gmail.com>]

On 12.04.2024 18:38, Stephen Hemminger wrote:
> On Fri, 12 Apr 2024 12:17:57 +0200
> Heiner Kallweit <hkallweit1@gmail.com> wrote:
> 
>> AFAICS all users of net_class take a const struct class * argument.
>> Therefore fully constify net_class.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> PS: net_class_attr can be const as well?

No, this results in warnings, because the const is at least discarded.

struct attribute_group {
	const char		*name;
	umode_t			(*is_visible)(struct kobject *,
					      struct attribute *, int);
	umode_t			(*is_bin_visible)(struct kobject *,
						  struct bin_attribute *, int);
	struct attribute	**attrs;
	struct bin_attribute	**bin_attrs;
};