From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1AC36B12 for ; Wed, 20 Sep 2023 14:03:19 +0000 (UTC) Received: from notapiano (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8A6936607201; Wed, 20 Sep 2023 15:03:10 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695218591; bh=0As1l5pUnNWGSkzZabr2JsNuZssFSpilRQkjdz8AJ1k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=igMB+AMiayEFp612LIiv/IJGUNWjv/yfNcI67RWl3fmXUEAusqwBRIlxTDEnn2i74 okinKpYzPipz6KpaHM6vvNcdzoEXqnTJ2BgQiVicY1/H3HXJHGjSAysNjpxU7HhdCs F5ZGEAKOmET+xH7LYlgwLFAJMwlcvTf/KRpwxU2fn4JmBJ5QOlVGdMJrEJoPX7bOvB twcnEEonoCMblVmogccUDxSIVxOChfpO4MI6qbNxW0kQh0YGDbPdJRKLlZxhsddiz6 ZMNqYv8Rg1RsUg86xJu1pzQnOcJAVnrGWtuFpq4W0DC1i2LZFeNKUErHFMEZd6klRr Efc5V3eD7jPiw== Date: Wed, 20 Sep 2023 10:03:06 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Rob Herring , Frank Rowand , Shuah Khan Cc: Mark Brown , kernelci@lists.linux.dev, kernel@collabora.com, Guenter Roeck , Bjorn Andersson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 0/3] Add a test to catch unprobed Devicetree devices Message-ID: <97c368a1-9c76-490a-848e-eacd6411e810@notapiano> References: <20230828211424.2964562-1-nfraprado@collabora.com> Precedence: bulk X-Mailing-List: kernelci@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230828211424.2964562-1-nfraprado@collabora.com> On Mon, Aug 28, 2023 at 05:13:09PM -0400, Nícolas F. R. A. Prado wrote: > > Regressions that cause a device to no longer be probed by a driver can > have a big impact on the platform's functionality, and despite being > relatively common there isn't currently any generic test to detect them. > As an example, bootrr [1] does test for device probe, but it requires > defining the expected probed devices for each platform. > > Given that the Devicetree already provides a static description of > devices on the system, it is a good basis for building such a test on > top. > > This series introduces a test to catch regressions that prevent devices > from probing. > > Patches 1 and 2 extend the existing dt-extract-compatibles to be able to > output only the compatibles that can be expected to match a Devicetree > node to a driver. Patch 2 adds a kselftest that walks over the > Devicetree nodes on the current platform and compares the compatibles to > the ones on the list, and on an ignore list, to point out devices that > failed to be probed. > > A compatible list is needed because not all compatibles that can show up > in a Devicetree node can be used to match to a driver, for example the > code for that compatible might use "OF_DECLARE" type macros and avoid > the driver framework, or the node might be controlled by a driver that > was bound to a different node. > > An ignore list is needed for the few cases where it's common for a > driver to match a device but not probe, like for the "simple-mfd" > compatible, where the driver only probes if that compatible is the > node's first compatible. > > The reason for parsing the kernel source instead of relying on > information exposed by the kernel at runtime (say, looking at modaliases > or introducing some other mechanism), is to be able to catch issues > where a config was renamed or a driver moved across configs, and the > .config used by the kernel not updated accordingly. We need to parse the > source to find all compatibles present in the kernel independent of the > current config being run. > > [1] https://github.com/kernelci/bootrr > > Changes in v3: > - Added DT selftest path to MAINTAINERS > - Enabled device probe test for nodes with 'status = "ok"' > - Added pass/fail/skip totals to end of test output > > Changes in v2: > - Extended dt-extract-compatibles script to be able to extract driver > matching compatibles, instead of adding a new one in Coccinelle > - Made kselftest output in the KTAP format > > Nícolas F. R. A. Prado (3): > dt: dt-extract-compatibles: Handle cfile arguments in generator > function > dt: dt-extract-compatibles: Add flag for driver matching compatibles > kselftest: Add new test for detecting unprobed Devicetree devices > > MAINTAINERS | 1 + > scripts/dtc/dt-extract-compatibles | 74 +++++++++++++---- > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/dt/.gitignore | 1 + > tools/testing/selftests/dt/Makefile | 21 +++++ > .../selftests/dt/compatible_ignore_list | 1 + > tools/testing/selftests/dt/ktap_helpers.sh | 70 ++++++++++++++++ > .../selftests/dt/test_unprobed_devices.sh | 83 +++++++++++++++++++ > 8 files changed, 236 insertions(+), 16 deletions(-) > create mode 100644 tools/testing/selftests/dt/.gitignore > create mode 100644 tools/testing/selftests/dt/Makefile > create mode 100644 tools/testing/selftests/dt/compatible_ignore_list > create mode 100644 tools/testing/selftests/dt/ktap_helpers.sh > create mode 100755 tools/testing/selftests/dt/test_unprobed_devices.sh Hi Rob, gentle ping on this series. I take it you'll be merging this through your tree, so I've added Shuah's R-b that she supplied on v2 for the kselftest patch. Thanks, Nícolas