From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12C5BC3DA63 for ; Tue, 23 Jul 2024 08:37:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.762839.1173060 (Exim 4.92) (envelope-from ) id 1sWB14-0003ZG-U1; Tue, 23 Jul 2024 08:37:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 762839.1173060; Tue, 23 Jul 2024 08:37:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sWB14-0003Z9-Qi; Tue, 23 Jul 2024 08:37:02 +0000 Received: by outflank-mailman (input) for mailman id 762839; Tue, 23 Jul 2024 08:37:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sWB13-0003Z3-8b for xen-devel@lists.xenproject.org; Tue, 23 Jul 2024 08:37:01 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba531d16-48ce-11ef-bbfe-fd08da9f4363; Tue, 23 Jul 2024 10:36:59 +0200 (CEST) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5a167b9df7eso5182176a12.3 for ; Tue, 23 Jul 2024 01:36:59 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5a30c2f88a5sm7155898a12.77.2024.07.23.01.36.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 01:36:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba531d16-48ce-11ef-bbfe-fd08da9f4363 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721723819; x=1722328619; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=V011ySCA2sWR2YZ2G4YKkT98XR8zrJAayITvz4Vl7nY=; b=UEJfkmnwSc/Oj2piz2jLRKGACnW7/0oPM3B/tstN4S15gKM6TobXqDZbPwwMfF8CRq Ylfk0hOyO4b+hljXQNxw5N8oxIzB74JzmM2WPSAwBVtf33UlAPONsI89+hOKEQcSB0nw uH64vJA7mOGLbAo3PPLV9NRO/zCTkPdVXbe51LFFoE7HmK7vOj7Lj8QZeiKY7tO5JVo1 7Z6SBj7/HwW+X6RJQWREHfXkiLkJvr3wKSzAUBg0vzzacTnGHycL5ZE11b0IrKVfFtgJ TBibz32Kkarb5myOBL9B9JUVM4uwCHg850tr4MdcCVGdtlVqQ3wu7lkUoVHsVSGs0/9y Anxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721723819; x=1722328619; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V011ySCA2sWR2YZ2G4YKkT98XR8zrJAayITvz4Vl7nY=; b=r0AmPjqKEAwP2WFPabkwnbepS2xyycrGrdmTeufs5hCudtO2hRjPFRHpZT7a7G+YXH bIjLJgWKIG1+T3eiuYWOBJeNfR3DHYj8VPyhjqC41CnOl7H25jD2/bWiagrUNvNX6T0H 380O8tgZFmZUUJaTew6aiaAJ2rUyBOGMulGo9jD1hlCcoGNA9JEKWdrlzpw3DRkBoEsH sXS4O/bNunk2crVezKG6DYGqX1UpsPkXinuqpm8OvN2tf4n1JK8f3p6NP1e1KZ5oXjGR /Rca0SgWNyK77ojxPFR7rgOE9nPFb5z3SimQrFL6Bju38YDIPPLFY8GiLDgLDhR6Czyq 37TQ== X-Forwarded-Encrypted: i=1; AJvYcCX0CojS7chsSwjEBSwuRTNS9GwSFuna0CDLL5uiMgEOxlKl1tdxLjwAsCfcrS88G0NnsCjZ5TMUpiaNJwFNkfmyXB4Bo0HlZBOIJZILLis= X-Gm-Message-State: AOJu0Yz2HWtz3wdEV19D880nffCcPMsBadBFIC0MVucyYtMMexCO3KNV a72f9glx3z6XDfEyoWkjFtQ3eWjhdYZx0JpjV+L3EWfesNYqvqggOR1PTUbv2w== X-Google-Smtp-Source: AGHT+IFi6zbXfxwnzww72RnBGGHbXqdMIVs8saSz+LCxIhYx4rRabmTNkLws2fNNgqu75Udu4X16TQ== X-Received: by 2002:a05:6402:27cf:b0:5a0:d754:5ec5 with SMTP id 4fb4d7f45d1cf-5a4795813a8mr7317789a12.26.1721723819342; Tue, 23 Jul 2024 01:36:59 -0700 (PDT) Message-ID: <97c82aca-0b8a-4b78-980b-0857dbdae80a@suse.com> Date: Tue, 23 Jul 2024 10:36:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header To: Oleksii Kurochko Cc: Oleksii Kurochko , Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , Stefano Stabellini , xen-devel@lists.xenproject.org, Julien Grall References: <6458c61d-5974-41c2-a1e6-76e4a15a487a@suse.com> <54af6fb751da1103054de2d79a2057bec658f399.camel@gmail.com> <623da862-8e76-4d40-9aa9-b02c8fd9944d@xen.org> <26ae01e2-d085-48d7-8b1f-da1e44b01e53@xen.org> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 23.07.2024 10:02, Oleksii Kurochko wrote: > On Mon, Jul 22, 2024 at 7:27 PM Julien Grall wrote: >>>> On 22/07/2024 15:44, Oleksii Kurochko wrote: >>> /* Map a 4k page in a fixmap entry */ >>> void set_fixmap(unsigned map, mfn_t mfn, unsigned int flags) >>> { >>> pte_t pte; >>> >>> pte = mfn_to_xen_entry(mfn, flags); >>> pte.pte |= PTE_LEAF_DEFAULT; >>> write_pte(&xen_fixmap[pt_index(0, FIXMAP_ADDR(map))], pte); >> >> It would be saner to check if you are not overwriting any existing >> mapping as otherwise you will probably need a TLB flush. >> >>> } >>> >>> /* Remove a mapping from a fixmap entry */ >>> void clear_fixmap(unsigned map) >>> { >>> pte_t pte = {0}; >>> write_pte(&xen_fixmap[pt_index(0, FIXMAP_ADDR(map))], pte); >> >> Don't you need a TLB flush? >> > Inside write_pte() there is "sfence.vma". That's just a fence though, not a TLB flush. Jan