From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 392B330DEDC for ; Fri, 16 Jan 2026 10:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768559587; cv=none; b=ajX7Kqykhi18DPBq6q/v/8vXsXVGWe4Mm00aYixaNr0SZp8vOH3aWxoQPgoSTd4XWEMQS1IN/vdrJIHApv8PRcwkjKyELs6hI0m5/lBFDJRzzWeZPs4GtJOdbO8qJJdHOrgTbEpC7EBOGkFU2eQAWZikpYKNc/wh9B1wNVpwgWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768559587; c=relaxed/simple; bh=hU3GamPapeXgHF3jdpAtkGPYOYhXod5YD9B4IzG0BMQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HxET9eMznJhLsWAFaTpO09CHgU+bsz7JudJPUK9sKTb7w6RlAlGC6Nw0l3mlHR3KQjClawGowk4haU9h/kFQNY/uXwjp+NxodoAis1f5hX/wmzRcWO8FDENWljV107oL/udfTQPQkHhjFxIxZRobXlUrmSz02H1FgPF3JFTT0ls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y/7HjC5w; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y/7HjC5w" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42fbc544b09so1319947f8f.1 for ; Fri, 16 Jan 2026 02:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768559584; x=1769164384; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dIL24P2ETxm0HUuHln7Y7jLrkrnH50tVwaHGqUNmGHM=; b=Y/7HjC5wnxsLw8z1HwmN6EG0jh8TafqbLpoBdB5E8SeMjxgRuJ/C+F0V4vBf5JYCOS 193xzcO4zRKbNYuGQkpRz1Kkxlr5zCMy8BbUkDKSyyTHmqewY/c6Z8w2rIEzTxNKnJdK ZtPUz+nA8R7Qc9cfmtonvCHlIbKlBC8Ybf7Q6f6aNnjqG6xRCNSeQ52lmWGWTGjX6LDZ eXvz6A80ZfybeOYsfwgSdaOaMQmf86qdt8QCuEFIxMscZTLlt5sxxmLgCKEl16f56+jQ PDJn7InrmjQ8bwqBOaYR53bVPPGoxLlDObYJ/UzBE4ONUe1oxtK5sgtDULcSfQwgzn77 U/KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768559584; x=1769164384; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dIL24P2ETxm0HUuHln7Y7jLrkrnH50tVwaHGqUNmGHM=; b=tNTejwM+2xARtiUYXnVAyr9nKesaHqADQ3RGfvgdxUdbW0kJMw+S41N0JyLT2a3jaz yXTh5Q7Z6/y5uVhLSJwJ9thd/86XNOHgLhxwf88qwybyp0gNMaimHhqqyZPzZ2QCjz7Q jDFsGMnHkFOx4PPLEFThK03bDGcPjzdn0EcsHjIhKo0+WlSP+qEvNNvX3vgKyVOdPVP+ XpprRSWkct2AoAy/k2RpQu57Rle1pOpbQxkbWZe1ckVISmw2stx3fru6tbbKglFQ4dfI 6F0gmlhZ5j3ts9LvGMnO/KT+RU/VmSup6UAMr8pgLS3Hra4GuvOI5ylbh4FNqixyhxVD 8xVg== X-Forwarded-Encrypted: i=1; AJvYcCVHo4Rw1bx1SpTQ5OKUbfZ0DHaUvSHT1xJS4sx3JQ8m9VTfQ48/1PxXPW0Az5TWo7nwxNpnKBjWE3nDxo8=@vger.kernel.org X-Gm-Message-State: AOJu0YwfBjGBNxDqhJzUd146Y43bgtQVNCyd6XkXAJC0kaDzgRSsvoTd GxwAIOwrrDet7B8CNcVlf6W38XTP6qt29sdOZLwP5pf8akLhXGOknXPD X-Gm-Gg: AY/fxX7EcGJVOXarex0MwdFxrxtG5ZKbtzpDWwtZ8FG9+L8TJI67S6RLFZ5/JwCQcTJ z2MSF5ESCCUlEBNJdg7Qpak39wSdc40GFJlNcTiaRRRmOrk6eD/xhAszZFocoOw9vqX1ru8+Val VsCIlbaDIxqFZdg/QvM3ojjS+sEkdQov5xCSOTICV+GKFuXbpuaoaZz68VCVzMj+QhhC/vcgZfc +8yXa6t1QkLCFTmgUGwcmKsnt4QVNV+XAyOLPx1PJgVWkr8tM0mKfVHfrssvEBWKepbPkWAh+6f 3vAvV1fjt0ZvcFABk6RwZP48F4TmowegyCaAywoV6S9V9Ee8lyRwkTa4lSpSAaV2zP3BZyoC3GY GFNN1yo4os5ElsPIgmD2P4nCmeS9nRZdP4YIPXrVaKef5AyLIblZAy+Qp1JbK7voszzYlKO1ZVx ZCI0sv21iiZqTe6MDZHbrF7sNgeo/kWyawe9D7mkFoutbR6z7G X-Received: by 2002:a5d:5f46:0:b0:431:3a5:d9c1 with SMTP id ffacd0b85a97d-43569bbaf1cmr2538953f8f.30.1768559584225; Fri, 16 Jan 2026 02:33:04 -0800 (PST) Received: from [192.168.178.118] (p54ad9059.dip0.t-ipconnect.de. [84.173.144.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996dad0sm4344413f8f.27.2026.01.16.02.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jan 2026 02:33:03 -0800 (PST) Message-ID: <97cab4b5-ab35-4cbe-a8ee-8ad6ea522159@gmail.com> Date: Fri, 16 Jan 2026 11:33:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mcb: Fix incorrect sanity check To: Jose Javier Rodriguez Barbarin Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org References: <20251120113732.24678-1-dev-josejavier.rodriguez@duagon.com> <6b6e7d3e-7219-4459-b177-1e4123c531be@gmail.com> <07831c5f-7cc1-41f5-b88e-ca3ece325e87@gmail.com> Content-Language: en-US From: Johannes Thumshirn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/16/26 11:30 AM, Jose Javier Rodriguez Barbarin wrote: > On Fri, Nov 21, 2025 at 11:54:08AM +0100, Johannes Thumshirn wrote: >> On 11/21/25 11:33 AM, Jose Javier Rodriguez Barbarin wrote: >>> On Thu, Nov 20, 2025 at 12:48:45PM +0100, Johannes Thumshirn wrote: >>>> On 11/20/25 12:37 PM, Jose Javier Rodriguez Barbarin wrote: >>>>> __mcb_register_driver() makes some sanity checks over mcb_driver >>>>> to check if .probe and .remove callbacks are set. However, not all >>>>> mcb device drivers implement .remove callback. >>>>> >>>>> Remove .remove check to ensure all mcb device drivers can be loaded. >>>> The only driver I can see that doesn't implement a .remove method is >>>> gpio-menz127.c. >>> Yes. In the past gpio-menz127.c also implemented .remove method, however in >>> >>> 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") >>> >>> The driver changed, using now devm_* functions so .remove was no longer necessary. >>> >>>> Is this safe? >>>> >>> From the point of view of mcb bus it should be safe becase I protected the call >>> of .remove on mcb_remove(), preventing possible crashes when the driver is removed >>> from the bus. >>> >>> I'm afraid I'm lossing something because I cannot understand why these changes are or >>> not safe. Could you explain me why you understand that these changes are unsafe? >> >> Thanks this is the information I was missing from the changelog. I'll change >> the commit message to: >> >> __mcb_register_driver() makes some sanity checks over mcb_driver >> to check if .probe and .remove callbacks are set. However, since commit >> 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") >> removed the .remove callback from menz127-gpio.c, not all mcb device >> drivers implement .remove callback. >> >> Remove .remove check to ensure all mcb device drivers can be loaded. >> >> I'll also add >> >> Fixes: 3bd13ae04ccc ("gpio: menz127: simplify error path and remove remove()") >> >> >> Thanks, >> >>     Johannes >> > Hi Johannes, > > I noticed this patch is not uploaded yet. > > I can submit it again changing the commit message as you commented above. > > Thank you, > > Javier R. Yes I wanted to forward it to Greg and then I forgot I'm sorry. But I think it's still in time for v6.20. I'll do so ASAP.