All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Michal Krawczyk <mk@semihalf.com>, dev@dpdk.org
Cc: gtzalik@amazon.com, igorch@amazon.com, mw@semihalf.com
Subject: Re: [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment
Date: Fri, 29 Jan 2021 12:07:01 +0000	[thread overview]
Message-ID: <97d9c7eb-7bc2-3076-b5bf-f835958ca483@intel.com> (raw)
In-Reply-To: <20210126183226.2420903-5-mk@semihalf.com>

On 1/26/2021 6:32 PM, Michal Krawczyk wrote:
> From: Igor Chauskin <igorch@amazon.com>
> 
> Before starting transmission of Tx burst, the driver checked the
> available space in the sq and limited the number of packets for
> transmission accordingly.
> The calculation was incorrect for fragmented packets and potentially had
> significantly limited the length of Tx bursts.
> 
> This patch removes the assessment and pushes packets to the sq as long
> as the burst is not exhausted and space is available in the sq.
> 
> Correct evaluation of the required space isn't possible before the burst
> because it depends on the number of segments of each packet.
> This patch adds per-packet space evaluation for each packet before
> attempting to process it. In case there is not enough queue space, the
> burst will just stop without error.
> 
> Signed-off-by: Igor Chauskin <igorch@amazon.com>
> Reviewed-by: Michal Krawczyk <mk@semihalf.com>

Hi Michal, Igor,

Can you please provide fixes line for the patch, and I assume you want it to be 
backported?


  reply	other threads:[~2021-01-29 12:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 18:32 [dpdk-dev] [PATCH v2 0/5] net/ena: minor bug fixes and improvements Michal Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 1/5] net/ena: flush Rx buffers memory pool cache Michal Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 2/5] net/ena: Tx doorbell statistics fix Michal Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 3/5] net/ena: validate Rx req id upon acquiring the desc Michal Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment Michal Krawczyk
2021-01-29 12:07   ` Ferruh Yigit [this message]
2021-01-29 12:16     ` Michał Krawczyk
2021-01-26 18:32 ` [dpdk-dev] [PATCH v2 5/5] net/ena: prevent double doorbell Michal Krawczyk
2021-01-29 12:07   ` Ferruh Yigit
2021-01-29 12:17 ` [dpdk-dev] [PATCH v2 0/5] net/ena: minor bug fixes and improvements Ferruh Yigit
2021-01-29 12:33   ` Michał Krawczyk
2021-01-29 15:15     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97d9c7eb-7bc2-3076-b5bf-f835958ca483@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mk@semihalf.com \
    --cc=mw@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.