Re: [PATCH mptcp-next] Squash to "bpf: Add mptcp_subflow bpf_iter"

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang, Mat,

On 27/02/2025 03:03, Geliang Tang wrote:
> Hi Matt,
> 
> On Wed, 2025-02-26 at 19:07 +0100, Matthieu Baerts (NGI0) wrote:
>> From what we understood, when being used from a CG [gs]etsockopt
>> hook,
>> the socket lock will be held. It seems that the BPF infra will make
>> sure
>> in this case. Mat will try to get the confirmation.
>>
>> The idea is then to add this msk_owned_by_me() check to make sure the
>> assumption is correct, and will continue to be: the new selftest
>> should
>> complain if not when used with a debug kconfig. In other words, if
>> the
>> tests continue to pass with this patch, the Squash-to series can
>> probably be applied.
>>
>> Note that this is just a debug check, hoping that the selftest will
>> cover all cases. We can then not use this check to return an error if
>> it
>> is not held.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> Thanks for updating this for me.
> 
> LGTM!
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you for the review!

>> ---
>> Based-on: <cover.1740368110.git.tanggeliang@kylinos.cn>
> 
> I changed the state of this set, Squash to "Add mptcp_subflow bpf_iter
> support" v4, together with this squash-to patch, as "Queued".

Thank you. If that's OK, I will wait for Mat's green light before
applying the patches, because he wanted to look at the BPF code to make
sure our assumption was correct.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.