From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F14C43334 for ; Mon, 6 Jun 2022 17:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229730AbiFFRR0 (ORCPT ); Mon, 6 Jun 2022 13:17:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbiFFRRI (ORCPT ); Mon, 6 Jun 2022 13:17:08 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E5FC213; Mon, 6 Jun 2022 10:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654535589; x=1686071589; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=RIIF6gQd50znOWXgHgd/G+ztiqR6/zdKxtaDENKnjZA=; b=eCzjQtr9bw57DQLcUrF5TZ/IHrzC5W6TogZcGdmDtUU3CrenzS4K/KOf AnLdbjwC6jpVlr6Hf6XXEAuk0gFQsdn7UWYhMsKdAFqONOjbJ02ec7ryj sfncFT7KShn1zn70fRmmNY1yAGOns5Pys1rWLwTY5Mx2kd7zVA9NaLeIG JKa68fTB9RlJQHxWesAHBAYeozZeFnK0IwEv5pjR5erlq0NHXFdlaBAwR jDUd0FhLSI5/BwNihI5w1oGB+aVc6MTQYxlnf1sbOwfaYRrQVQ5in1vug /3lz3E/Khl1Xh/t7s/qwS6dVBziFkJRm847XL4OtHiKKlxxpg0JnPXOr+ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="277060677" X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="277060677" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 09:52:25 -0700 X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="825912993" Received: from amkossek-mobl1.ger.corp.intel.com ([10.252.57.11]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 09:52:21 -0700 Date: Mon, 6 Jun 2022 19:52:19 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Andy Shevchenko cc: Greg KH , linux-serial , Jiri Slaby , "Matwey V. Kornilov" , LKML , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= Subject: Re: [PATCH v2 1/6] serial: 8250: Store to lsr_save_flags after lsr read In-Reply-To: Message-ID: <97e83f-8011-37fb-d958-2d881fcdbd3@linux.intel.com> References: <20220606131124.53394-1-ilpo.jarvinen@linux.intel.com> <20220606131124.53394-2-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-455783549-1654534344=:1547" Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-455783549-1654534344=:1547 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 6 Jun 2022, Andy Shevchenko wrote: > On Mon, Jun 6, 2022 at 3:55 PM Ilpo Järvinen > wrote: > > On Mon, 6 Jun 2022, Ilpo Järvinen wrote: > > ... > > > > Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250") > > > Link: https://lore.kernel.org/all/1d6c31d-d194-9e6a-ddf9-5f29af829f3@linux.intel.com/T/#m1737eef986bd20cf19593e344cebd7b0244945fc > > > Signed-off-by: Uwe Kleine-König > > > Acked-by: Uwe Kleine-König > > > > It seems that Uwe managed to mistype his email for the A-by which I just > > happily copy-pasted. > > > > Greg, please let me know if you want me to resend the series (or if you > > will just change it on the fly while applying). > > I believe Greg doesn't handle patches on the fly, hence resend. > But more importantly I do not see the reason for the Acked-by tag when > SoB of the same person is present. I just repeated what Uwe gave me. Maybe he didn't notice he was already there as SoB. This situation is anyway a bit more complex than usual. The line I took was part of Uwe's much larger patch initially (which was fully reverted) so his SoB was carried over to preserve the authorship. As I made a non-trivial modification to his original patch by removing almost all of it, I added my SoB too. Given this situation, I kind of thought he Acked (approved) the post-modification version of it. -- i. --8323329-455783549-1654534344=:1547--