From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/rcar-du: Add missing dependency on CMA
Date: Wed, 10 Jul 2013 12:54:40 +0200
Message-ID: <9815009.SJ9cp8Rvrj@avalon>
References: <1373453534-6425-1-git-send-email-broonie@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
	[95.142.166.194])
	by gabe.freedesktop.org (Postfix) with ESMTP id EE54BE5F99
	for <dri-devel@lists.freedesktop.org>;
	Wed, 10 Jul 2013 03:54:05 -0700 (PDT)
In-Reply-To: <1373453534-6425-1-git-send-email-broonie@kernel.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Mark Brown <broonie@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, dri-devel@lists.freedesktop.org, Mark Brown <broonie@linaro.org>
List-Id: dri-devel@lists.freedesktop.org

Hi Mark,

Thanks for the patch.

On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> The driver uses CMA APIs so won't link if CMA is not being built.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  drivers/gpu/drm/rcar-du/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig
> b/drivers/gpu/drm/rcar-du/Kconfig index 72887df..e75575a 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -1,6 +1,6 @@
>  config DRM_RCAR_DU
>  	tristate "DRM Support for R-Car Display Unit"
> -	depends on DRM && ARM
> +	depends on DRM && ARM && CMA
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_CMA_HELPER
>  	select DRM_GEM_CMA_HELPER

Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?

-- 
Regards,

Laurent Pinchart