From: Thomas Monjalon <thomas@monjalon.net>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, stable@dpdk.org,
Ciara Power <ciara.power@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Shaowei Sun <1819846787@qq.com>
Subject: Re: [PATCH] telemetry: lower log level on socket error
Date: Wed, 19 Jun 2024 16:37:23 +0200 [thread overview]
Message-ID: <9824270.uMvqGB8zbg@thomas> (raw)
In-Reply-To: <CAATJJ0Kd7_dP=kB2Du_sfkVLjF-18Y3vXjs2cwW-6De2s8yrqQ@mail.gmail.com>
06/06/2024 15:26, Christian Ehrhardt:
> On Thu, Jun 6, 2024 at 2:27 PM David Marchand <david.marchand@redhat.com> wrote:
> >
> > When starting two DPDK programs using the same DPDK prefix (like for
> > example OVS and testpmd, both running as primary processes in
> > --in-memory mode), the first DPDK process of the two spews some error
> > log when the second starts:
> >
> > TELEMETRY: Socket write base info to client failed
> >
> > This is because telemetry init involves trying to connect on existing
> > sockets to check if it can take over an existing socket file.
> >
> > On the other hand, this error log provides no helpful information.
> > Lower this log to debug level.
>
> I agree, it is useful info in rare occasions, but not a "please
> consider having a panic" error level.
> Thank you for polishing all edges of this one issue that I raised originally!
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Where did you raise it? I don't find it in emails.
next prev parent reply other threads:[~2024-06-19 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 12:26 [PATCH] telemetry: lower log level on socket error David Marchand
2024-06-06 13:26 ` Christian Ehrhardt
2024-06-19 14:37 ` Thomas Monjalon [this message]
2024-06-17 14:28 ` Bruce Richardson
2024-06-17 14:39 ` Stephen Hemminger
2024-06-17 14:52 ` Bruce Richardson
2024-06-17 15:13 ` Stephen Hemminger
2024-06-19 15:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9824270.uMvqGB8zbg@thomas \
--to=thomas@monjalon.net \
--cc=1819846787@qq.com \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.