All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: dm-devel@lists.linux.dev, Mike Snitzer <snitzer@kernel.org>,
	 Christoph Hellwig <hch@lst.de>,
	Benjamin Marzinski <bmarzins@redhat.com>
Subject: Re: [PATCH v2] dm-delay: Prevent zoned write reordering on suspend
Date: Tue, 22 Apr 2025 20:42:59 +0200 (CEST)	[thread overview]
Message-ID: <9825d394-19f3-d454-4c86-93a9c2fc798e@redhat.com> (raw)
In-Reply-To: <6d4718f8-49c2-451f-8253-37a0ba039c80@kernel.org>



On Tue, 22 Apr 2025, Damien Le Moal wrote:

> It is not because you do not see a clean solution that there is not one. So
> unless you have completely made up your mind already and are not willing to

I haven't made up my mind completely.

> I do not understand what you are talking about. A zoned DM device is zoned
> because it is on top of a zoned device. That bottom zoned device may be another
> DM target or a real zoned device. For the real zoned device, zone write plugging
> is always used so it does not matter if the host controller does or does not
> preserve command order.

I understand that. I don't understand why can't DM devices also use write 
plugging. What kind of problem are you trying to fix - a performance 
problem or a correctness problem?

> There will always be at most 1 in-flight write per zone, which makes 
> reordering of commands completely irrelevant for write commands success.

If reordering is irrelevant for the underlying device, why is it relevant 
for DM?

If the host controller may reorder commands (as you say), why can't DM do 
it?

Mikulas


      reply	other threads:[~2025-04-22 18:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11  0:04 [PATCH v2] dm-delay: Prevent zoned write reordering on suspend Damien Le Moal
2025-04-11 21:01 ` Benjamin Marzinski
2025-04-14 13:19 ` Mikulas Patocka
2025-04-15  8:08   ` Damien Le Moal
2025-04-16 12:45     ` Mikulas Patocka
2025-04-17 22:15       ` Damien Le Moal
2025-04-22 11:27         ` Mikulas Patocka
2025-04-22 12:20           ` Damien Le Moal
2025-04-22 18:42             ` Mikulas Patocka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9825d394-19f3-d454-4c86-93a9c2fc798e@redhat.com \
    --to=mpatocka@redhat.com \
    --cc=bmarzins@redhat.com \
    --cc=dlemoal@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.