From: Alex Dubov <oakad@yahoo.com>
To: Andy Fleming <afleming@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Daney <ddaney@caviumnetworks.com>,
netdev@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [Bugme-new] [Bug 33042] New: Marvell 88E1145 phy configured incorrectly in fiber mode
Date: Sun, 17 Apr 2011 23:43:10 -0700 (PDT) [thread overview]
Message-ID: <983551.33255.qm@web37601.mail.mud.yahoo.com> (raw)
In-Reply-To: <BANLkTikJ60ND7s5-jfGTBDG3BoM-294CSA@mail.gmail.com>
--- On Sat, 16/4/11, Andy Fleming <afleming@gmail.com> wrote:
>
> You could probably change to use a fixed link by removing
> the
> phy-handle property from your ethernet device node, and
> adding:
> "fixed-link=<0 1000 1 0 0>". If that works,
> then the issue is that
> Linux is breaking something when it connects. It might be
> good enough
> for you to use fixed-link, though it would be good to
> actually find
> out what's going wrong with the PHY driver.
>
It seems, I found my problem. On the linux side it purely amount to this:
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -803,7 +803,7 @@ static struct phy_driver marvell_drivers[] = {
.flags = PHY_HAS_INTERRUPT,
.config_init = &m88e1145_config_init,
.config_aneg = &marvell_config_aneg,
- .read_status = &genphy_read_status,
+ .read_status = &marvell_read_status,
.ack_interrupt = &marvell_ack_interrupt,
.config_intr = &marvell_config_intr,
.driver = { .owner = THIS_MODULE },
But then I managed to accidentally put an incorrect value of the phy
interrupt into dts file and it caused all kinds of weird problems.
Shall I send a one-liner patch for the above?
prev parent reply other threads:[~2011-04-18 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-33042-10286@https.bugzilla.kernel.org/>
2011-04-11 21:02 ` [Bugme-new] [Bug 33042] New: Marvell 88E1145 phy configured incorrectly in fiber mode Andrew Morton
2011-04-11 21:18 ` David Daney
2011-04-12 3:45 ` Alex Dubov
2011-04-12 16:34 ` David Daney
2011-04-13 18:01 ` Andy Fleming
2011-04-14 7:59 ` Alex Dubov
2011-04-15 20:57 ` Andy Fleming
2011-04-18 5:44 ` Alex Dubov
2011-04-18 6:43 ` Alex Dubov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=983551.33255.qm@web37601.mail.mud.yahoo.com \
--to=oakad@yahoo.com \
--cc=afleming@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=ddaney@caviumnetworks.com \
--cc=grant.likely@secretlab.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.