Re: [Intel-gfx] [PATCH] drm/i915/gt: Increase MCR lock timeout

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 03/10/2023 22:08, Jonathan Cavitt wrote:
> Increase the timeout MCR waits for the steering semaphore
> in intel_gt_mcr_lock by a factor of 10.

Ideally you mention why in the commit message, with some appropriate 
level of detail depending on the situation.

+Matt for MCR stuff.

Regards,

Tvrtko

> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> index 326c2ed1d99bb..e3f7fb1248809 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> @@ -378,7 +378,7 @@ void intel_gt_mcr_lock(struct intel_gt *gt, unsigned long *flags)
>   	 */
>   	if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 70))
>   		err = wait_for(intel_uncore_read_fw(gt->uncore,
> -						    MTL_STEER_SEMAPHORE) == 0x1, 100);
> +						    MTL_STEER_SEMAPHORE) == 0x1, 1000);
>   
>   	/*
>   	 * Even on platforms with a hardware lock, we'll continue to grab