From: Ozgur Karatas <okaratas@member.fsf.org>
To: david@fromorbit.com
Cc: linux-xfs@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/1] Fixed to codestyle
Date: Mon, 12 Dec 2016 12:53:30 +0200 [thread overview]
Message-ID: <987271481540010@web27o.yandex.ru> (raw)
Hello,
I have error to use uuid and I think the functions should be used when -i'm eye-catching- "(* uuid)".
I tested it.
Regards,
Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
---
diff --git a/fs/xfs/uuid.c b/fs/xfs/uuid.c
index b83f76b..cd8bc8e 100644
--- a/fs/xfs/uuid.c
+++ b/fs/xfs/uuid.c
@@ -33,7 +33,7 @@ typedef struct {
* it just something that's needed for user-level file handles.
*/
void
-uuid_getnodeuniq(uuid_t *uuid, int fsid [2])
+uuid_getnodeuniq(uuid_t (*uuid), int fsid [2])
{
xfs_uu_t *uup = (xfs_uu_t *)uuid;
@@ -51,8 +51,8 @@ uuid_is_nil(uuid_t *uuid)
if (uuid == NULL)
return 0;
/* implied check of version number here... */
- for (i = 0; i < sizeof *uuid; i++)
- if (*cp++) return 0; /* not nil */
+ for (i = 0; i < sizeof (*uuid); i++)
+ if (*cp++) return 0; /* not nil */
return 1; /* is nil */
}
--
2.1.4
next reply other threads:[~2016-12-12 11:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 10:53 Ozgur Karatas [this message]
2016-12-12 13:49 ` [PATCH 1/1] Fixed to codestyle Eric Sandeen
2016-12-12 18:14 ` Joe Perches
2016-12-12 18:35 ` Eric Sandeen
2016-12-12 20:34 ` Ozgur Karatas
2016-12-12 20:41 ` Eric Sandeen
2016-12-12 20:49 ` Ozgur Karatas
2016-12-12 20:50 ` Joe Perches
2016-12-12 20:54 ` Ozgur Karatas
2016-12-12 21:17 ` Eric Sandeen
2016-12-12 20:31 ` Ozgur Karatas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=987271481540010@web27o.yandex.ru \
--to=okaratas@member.fsf.org \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.