All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: "David S. Miller" <davem@redhat.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4.6-pre3 unresolved symbol do_softirq
Date: Wed, 13 Jun 2001 23:58:05 +1000	[thread overview]
Message-ID: <9878.992440685@ocs4.ocs-net> (raw)
In-Reply-To: Your message of "Wed, 13 Jun 2001 05:13:02 MST." <15143.22734.747077.588558@pizda.ninka.net>

On Wed, 13 Jun 2001 05:13:02 -0700 (PDT), 
"David S. Miller" <davem@redhat.com> wrote:
>Keith Owens writes:
> > do_softirq is called from asm code which does not get preprocessed.
> > It needs to be exported with no version.
>
>It can get preprocessed if you know how.  Simply use the "i" asm
>constraint for an extra argument, and use the symbol there.  For
>example:
>
>	__asm__("%0" : : "i" (my_versioned_symbol));
>
>It works and we've been doing it on sparc for ages.

It works for integers but call do_softirq is more of a problem.  I
could not find an asm constraint that generated correct code in a
single instruction.  The closest I could get was
  __asm__("call *%%eax" : : "a" (do_softirq));
The 'obvious'
  __asm__("call %0" : : "m" (do_softirq));
calls to a location that contains the address of do_softirq, oops.

Any other architectures that call do_softirq inside asm would need
similar hard coding of indirect branches.  It is simpler to export
do_softirq with no version, and have cleaner asm.


  parent reply	other threads:[~2001-06-13 13:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-13 12:07 [patch] 2.4.6-pre3 unresolved symbol do_softirq Keith Owens
2001-06-13 12:13 ` David S. Miller
2001-06-13 13:48   ` Jeff Garzik
2001-06-13 13:58     ` David S. Miller
2001-06-13 14:03     ` Keith Owens
2001-06-13 14:06       ` David S. Miller
2001-06-13 14:11         ` Keith Owens
2001-06-13 14:15           ` David S. Miller
2001-06-13 14:37             ` Keith Owens
2001-06-13 13:58   ` Keith Owens [this message]
2001-06-13 14:01     ` David S. Miller
2001-06-13 14:09       ` Keith Owens
2001-06-13 14:21         ` David S. Miller
2001-06-13 14:37           ` Andrew Morton
2001-06-13 14:44           ` Andreas Schwab
2001-06-13 14:53             ` Russell King
2001-06-13 14:55             ` David S. Miller
2001-06-13 16:39               ` Keith Owens
2001-06-13 14:52           ` Russell King
2001-06-13 14:31         ` Bill Pringlemeir
2001-06-13 14:39           ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9878.992440685@ocs4.ocs-net \
    --to=kaos@ocs.com.au \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.