From: <Ajay.Kathat@microchip.com>
To: <marex@denx.de>, <alexis.lothore@bootlin.com>,
<linux-wireless@vger.kernel.org>
Cc: <davem@davemloft.net>, <adham.abozaeid@microchip.com>,
<claudiu.beznea@tuxon.dev>, <conor+dt@kernel.org>,
<edumazet@google.com>, <kuba@kernel.org>, <kvalo@kernel.org>,
<krzk+dt@kernel.org>, <pabeni@redhat.com>, <robh@kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] wifi: wilc1000: Rework bus locking
Date: Thu, 7 Nov 2024 01:28:43 +0000 [thread overview]
Message-ID: <9888f605-ee68-4bd3-8d1d-aeef247d23d0@microchip.com> (raw)
In-Reply-To: <16e5c8d7-64ac-424e-9430-b683ae16a34e@denx.de>
Hi Marek,
On 11/4/24 04:44, Marek Vasut wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On 10/23/24 8:47 PM, Marek Vasut wrote:
>
> Hello again,
>
>>> Is power-save enabled during the test. With PS enabled, The SDIO
>>> commands may
>>> fail momentarily but it should recover.
>>
>> It seems it gets enabled after first ifconfig up, that's a good hint,
>> I'll try to disable it and see if that makes them errors go away. Thanks!
>>
>> Do you have any details on WHY would such sporadic errors occur and how
>> to make those go away even with PS enabled ?
> Can you explain why does uAPSD (iw ...set power_save off) adversely
> affect SDIO bus stability ?
>
SDIO bus errors can occur for different reasons and those errors can be of
recoverable or non-recoverable type. For non-recoverable failures like
firmware crashes, the retry mechanism may not help to resolve the issue. If
the error is recoverable then driver should work with retry attempts.
I think you are observing the bus errors messages and it is recovering after
that. Is my understanding correct?
With the previous shared test procedure, which makes the interface up/down
continuously, the station may not go into the Doze/Awake sequence since that
mode switching gets activated after connection with AP.
> Can you explain how to prevent that or shall we disable uAPSD altogether ?
Could you please share the test procedure and logs. I am occupied at the
moment but I shall make some time to look into it and get a better understanding.
Regard,
Ajay
next prev parent reply other threads:[~2024-11-07 1:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 1:38 [PATCH] wifi: wilc1000: Rework bus locking Marek Vasut
2024-10-22 10:43 ` Alexis Lothoré
2024-10-22 13:19 ` Marek Vasut
2024-10-23 7:17 ` Ajay.Kathat
2024-10-23 14:44 ` Marek Vasut
2024-10-23 17:54 ` Ajay.Kathat
2024-10-23 18:47 ` Marek Vasut
2024-11-04 11:44 ` Marek Vasut
2024-11-07 1:28 ` Ajay.Kathat [this message]
2024-11-07 16:10 ` Marek Vasut
2024-11-15 14:33 ` Marek Vasut
2024-11-15 20:04 ` Ajay.Kathat
2024-11-16 19:57 ` Marek Vasut
2024-11-21 1:39 ` Marek Vasut
2024-10-23 7:54 ` Alexis Lothoré
2024-10-23 14:26 ` Marek Vasut
2024-10-22 20:33 ` kernel test robot
2024-10-23 1:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9888f605-ee68-4bd3-8d1d-aeef247d23d0@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=alexis.lothore@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.