From: Zenghui Yu <zenghui.yu@linux.dev>
To: Pengyu Zhang <zpenya1314@gmail.com>
Cc: corbet@lwn.net, rppt@kernel.org, linus.walleij@linaro.org,
fmdefrancesco@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] Docs/mm: Fix a mistakes for pfn in page_tables.rst
Date: Wed, 9 Oct 2024 00:25:54 +0800 [thread overview]
Message-ID: <988d7c7d-dedd-4ceb-ad8a-9a9962b7bb0c@linux.dev> (raw)
In-Reply-To: <20241008161050.14732-1-zpenya1314@gmail.com>
s/mistakes/mistake/ in the Subject line.
On 2024/10/9 00:10, Pengyu Zhang wrote:
> The documentation incorrectly calculate the pfn value as 0x3fffff,
> which should be 0x3ffff instead.It is obtained by right-shifting
^
Add a space.
> 0xffffc000 by 14 bits.
>
> This patch corrects the value to prevent any potential confusion
> for developers referencing this document.
>
> Signed-off-by: Pengyu Zhang <zpenya1314@gmail.com>
> ---
> Documentation/mm/page_tables.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/mm/page_tables.rst b/Documentation/mm/page_tables.rst
> index be47b192a596..e7c69cc32493 100644
> --- a/Documentation/mm/page_tables.rst
> +++ b/Documentation/mm/page_tables.rst
> @@ -29,7 +29,7 @@ address.
> With a page granularity of 4KB and a address range of 32 bits, pfn 0 is at
> address 0x00000000, pfn 1 is at address 0x00001000, pfn 2 is at 0x00002000
> and so on until we reach pfn 0xfffff at 0xfffff000. With 16KB pages pfs are
> -at 0x00004000, 0x00008000 ... 0xffffc000 and pfn goes from 0 to 0x3fffff.
> +at 0x00004000, 0x00008000 ... 0xffffc000 and pfn goes from 0 to 0x3ffff.
>
> As you can see, with 4KB pages the page base address uses bits 12-31 of the
> address, and this is why `PAGE_SHIFT` in this case is defined as 12 and
Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>
prev parent reply other threads:[~2024-10-08 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 16:10 [PATCH v1] Docs/mm: Fix a mistakes for pfn in page_tables.rst Pengyu Zhang
2024-10-08 16:18 ` Mike Rapoport
2024-10-08 16:25 ` Zenghui Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=988d7c7d-dedd-4ceb-ad8a-9a9962b7bb0c@linux.dev \
--to=zenghui.yu@linux.dev \
--cc=corbet@lwn.net \
--cc=fmdefrancesco@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=zpenya1314@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.