From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794905617; b=hQN9uwjRDj/IqZPCnDdGnp4zQA1QQOcMd6AwcQ2WjZlsoiEkhW3Ard0ZKWL5irqwFtXa KAqOLApvfwlMiOqDhxU3FRdhYoHd9rvFPzuoJ/LXP500XXGrhHCk7ffcSZWMU8RVYKqKx MR9xbZnDmd9hgFdCDwQcrG9ipMstsMoLGjSd9M29wMMe+zba49ljt1HdaGKSHgj+WFajk nnrDpFD3m/eKZ6nZCVCzq49fL1hKq/YzngMQP2IW3mlWbplu+ZtF5K6U8R/T1/9G07QTI yBtxAG5K+JSX3GwlKLydFqeCX5gtitWC08HWgZCNcykCuQlDzDTYdVqsNmEuPszcePw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794905617; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent:Cc: Subject:To:References:Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=MftBNpktnSoHTLOmINdSqknygeCyoEnFPuRaamj6H9s=; b=iMEOke+NitHEMsOkHDzwYotmVq7IZJaTdCLQbJxrqm6yhpFa4Iak5VgTYsk/j0t7/Te+ b/oVp34tg+IhGODvohZ2kRAAA4eX2AuTdriKnkqV6qD+JJ3yrSdgcDVH0ulwl0c4cQwoX U8ANiAHE2HzDTTBZ5smamA53ihaBsAVmvIfrkHfqKLKueoJIz+d34kEdlLMiqa4v4v+xD tLOAo1e7XtFGFb+PuEgnIMc25ie88TGzXYn1a3OY+D9d8qF3p8NPwSlJ50w2HjyWVTSo+ dhDkRzVpZv+Sa2hopZT7Cv2skd95pJtTl+Uc4psyYayt4wStBrUTbMXO8OGGovmuOhQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=es9T6PVy; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8694D606A31C for ; Tue, 17 Nov 2026 08:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=es9T6PVy Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4546B1F000C4; Tue, 17 Nov 2026 08:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794905617; bh=MftBNpktnSoHTLOmINdSqknygeCyoEnFPuRaamj6H9s=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=es9T6PVyNsMXDbdKe5FRNjGteCT4yL3FV1PWNol64kqfvd0ndnTIn4z82MSOeklP5 xackAc4xEhKgvmC6Dk93GDbCX05IiPntQgHhfX+Ou/ddEo4a4s11k8GSl6qnfJE7+K 9FvS2oqY0UGx6TD5I+VggDMhQfp8xw3PawjnTe+7qp97qG/GauGaIzxlByVXBfaDZb vdqQBIAO6HsDxQy8ier0QnudxUWKA/HQFgSYi9Yhga/XBwj4WCJ3bFyZEeXhPHhyYJ VrHec/UW70UwMqw2J2FuMTgYrjH8YS/l8KNw7U3gzEYsuJaCKM0Je1DTDkZxyE7CXo ynrkl2IRed/uw== Message-ID: <98904a3a-4a34-4e87-8e17-df1a5d385c35@kernel.org> Date: Tue, 17 Nov 2026 16:53:34 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Daeho Jeong Subject: Re: [f2fs-dev] [PATCH v2 01/20] f2fs: use block-based index and size calculations in more paths To: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com References: <20261116040851.2849696-1-daeho43@gmail.com> <20261116040851.2849696-2-daeho43@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20261116040851.2849696-2-daeho43@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/16/26 12:08, Daeho Jeong wrote: > From: Daeho Jeong > > Several paths still convert between file offsets and block indices with > PAGE_SHIFT or PAGE_SIZE, assuming that a page holds exactly one > filesystem block. Use the F2FS_BLK_* helpers there so that they stay > correct when the block size is smaller than PAGE_SIZE. > > No functional change when the block size equals PAGE_SIZE, except on > 32-bit architectures: __complete_revoke_list() now computes the > truncation offset and __clone_blkaddrs() the new i_size in 64 bits, so > that they no longer overflow beyond 4GB. > > Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBEF6606A31C for ; Tue, 17 Nov 2026 08:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.a=rsa-sha256 header.s=beta header.b=HvVAfDU5; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.a=rsa-sha256 header.s=x header.b=CsDDtYWZ; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.a=rsa-sha256 header.s=x header.b=QWj/JyzA; dkim=neutral header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=es9T6PVy DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=d22g6Q3wI91JZwfmVz3Nv1I7dMM1nysAtCqdxPYFbls=; b=HvVAfDU5qKIebj Zs1/C0mEeNvgjGnDaZYRu2Fpkzs5A15zYsAgHI2qVPJGgv/xmhVTRBlaX6Kj86yuGsK/4hYdIRaUL CQ5dECGrZOWRK27JyZNELf+UIKXtOYTVCp1kzkgtYkDbGyj2FLdKLnGVYFN+Y998TfSGl2XJZ8eON fi4=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xTEwk-000000007KJ-2Sxt; Tue, 17 Nov 2026 08:53:46 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xTEwi-000000007K1-37Qx for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 Nov 2026 08:53:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MftBNpktnSoHTLOmINdSqknygeCyoEnFPuRaamj6H9s=; b=CsDDtYWZz5Z4UF+bA4YUXIpgiP GZANLflDkuG3wmBJLv7Sw4pJ4wbCml82+oZozaCqFKykD6euZ2qtugMcxVcRls5RynIIpnRZdqJAE eI5Z/OFKXEB1IW9TQv9ZT0VnT7ebd57wm2SgslUSo7gW8SnGSCO4AlgBx6pu1ttwirdU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MftBNpktnSoHTLOmINdSqknygeCyoEnFPuRaamj6H9s=; b=QWj/JyzAhlSJLanwmhbFvx0Wc6 iVoY4h/PUqg2bWSE/sEJVl9WBp0SI195RWPB0DZH6JEyfKghRpY9ZIuaMzkUvUyZguvByZEivjgHq T9tgMotsK20mwt+IxtgLpvBT81J73WgqVa9sTSlNwSgSJOE3TOWVGPtxtxS6XdKTU1E0=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xTEwh-000000002hL-1JEI for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 Nov 2026 08:53:44 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 973D061260; Tue, 17 Nov 2026 08:53:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4546B1F000C4; Tue, 17 Nov 2026 08:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794905617; bh=MftBNpktnSoHTLOmINdSqknygeCyoEnFPuRaamj6H9s=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=es9T6PVyNsMXDbdKe5FRNjGteCT4yL3FV1PWNol64kqfvd0ndnTIn4z82MSOeklP5 xackAc4xEhKgvmC6Dk93GDbCX05IiPntQgHhfX+Ou/ddEo4a4s11k8GSl6qnfJE7+K 9FvS2oqY0UGx6TD5I+VggDMhQfp8xw3PawjnTe+7qp97qG/GauGaIzxlByVXBfaDZb vdqQBIAO6HsDxQy8ier0QnudxUWKA/HQFgSYi9Yhga/XBwj4WCJ3bFyZEeXhPHhyYJ VrHec/UW70UwMqw2J2FuMTgYrjH8YS/l8KNw7U3gzEYsuJaCKM0Je1DTDkZxyE7CXo ynrkl2IRed/uw== Message-ID: <98904a3a-4a34-4e87-8e17-df1a5d385c35@kernel.org> Date: Tue, 17 Nov 2026 16:53:34 +0800 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Daeho Jeong , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com References: <20261116040851.2849696-1-daeho43@gmail.com> <20261116040851.2849696-2-daeho43@gmail.com> Content-Language: en-US In-Reply-To: <20261116040851.2849696-2-daeho43@gmail.com> X-Spam-Score: -0.2 (/) X-Headers-End: 1xTEwh-000000002hL-1JEI Subject: Re: [f2fs-dev] [PATCH v2 01/20] f2fs: use block-based index and size calculations in more paths X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: Daeho Jeong Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/16/26 12:08, Daeho Jeong wrote: > From: Daeho Jeong > > Several paths still convert between file offsets and block indices with > PAGE_SHIFT or PAGE_SIZE, assuming that a page holds exactly one > filesystem block. Use the F2FS_BLK_* helpers there so that they stay > correct when the block size is smaller than PAGE_SIZE. > > No functional change when the block size equals PAGE_SIZE, except on > 32-bit architectures: __complete_revoke_list() now computes the > truncation offset and __clone_blkaddrs() the new i_size in 64 bits, so > that they no longer overflow beyond 4GB. > > Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel