From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D4FC433DB for ; Thu, 11 Feb 2021 17:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F56C64E79 for ; Thu, 11 Feb 2021 17:15:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232171AbhBKRPX (ORCPT ); Thu, 11 Feb 2021 12:15:23 -0500 Received: from mga04.intel.com ([192.55.52.120]:4719 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbhBKQMa (ORCPT ); Thu, 11 Feb 2021 11:12:30 -0500 IronPort-SDR: 4ZiQKTlxAmdhQdND4fQeeOBeVm9sfXxgtTQ2ktYUSyxtDBvmrbAV85kccFPIG3hXqAa+hwbCoR eDRUqaWt3ZCA== X-IronPort-AV: E=McAfee;i="6000,8403,9892"; a="179707358" X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="179707358" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 08:11:34 -0800 IronPort-SDR: AnEqEOS4EETBMPL/ToQ+rFZDaxlzewFj7BulAEU1GsWTwWVRk46wiR+O9PSc1CQE2i+L1Irv8m ltaWIXR1WHhA== X-IronPort-AV: E=Sophos;i="5.81,170,1610438400"; d="scan'208";a="362547479" Received: from djiang5-mobl1.amr.corp.intel.com (HELO [10.212.225.14]) ([10.212.225.14]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2021 08:11:33 -0800 Subject: Re: [PATCH v3] driver core: auxiliary bus: Fix calling stage for auxiliary bus init To: Greg KH Cc: rafael@kernel.org, linux-kernel@vger.kernel.org, Jacob Pan , Dave Ertman , Dan Williams References: <20210210201611.1611074-1-dave.jiang@intel.com> From: Dave Jiang Message-ID: <9896ca8c-f4c3-a4d2-05fd-675cd53069dd@intel.com> Date: Thu, 11 Feb 2021 09:11:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/2021 12:44 AM, Greg KH wrote: > On Wed, Feb 10, 2021 at 01:16:11PM -0700, Dave Jiang wrote: >> MODULE_LICENSE("GPL v2"); >> MODULE_DESCRIPTION("Auxiliary Bus"); >> MODULE_AUTHOR("David Ertman "); > As this code can not be built as a module, can you remove these lines as > well? I don't think they do anything, and were never needed. Ok I will remove them. > thanks, > > greg k-h