All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rohit Kumar <rohitkr@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
	agross@kernel.org, alsa-devel@alsa-project.org,
	bgoswami@codeaurora.org, bjorn.andersson@linaro.org,
	broonie@kernel.org, devicetree@vger.kernel.org,
	lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, perex@perex.cz,
	plai@codeaurora.org, robh+dt@kernel.org,
	srinivas.kandagatla@linaro.org, tiwai@suse.com
Cc: Ajit Pandey <ajitp@codeaurora.org>
Subject: Re: [PATCH v4 01/12] ASoC: qcom: Add common array to initialize soc based core clocks
Date: Thu, 6 Aug 2020 09:29:48 +0530	[thread overview]
Message-ID: <989f1d99-3cd0-e725-3f6d-43facf1ec04d@codeaurora.org> (raw)
In-Reply-To: <159667391634.1360974.15763918681460437981@swboyd.mtv.corp.google.com>

Thanks Stephen for reviewing.

On 8/6/2020 6:01 AM, Stephen Boyd wrote:
> Quoting Rohit kumar (2020-07-22 03:31:44)
>> From: Ajit Pandey <ajitp@codeaurora.org>
>>
>> LPASS variants have their own soc specific clocks that needs to be
>> enabled for MI2S audio support. Added a common variable in drvdata to
>> initialize such clocks using bulk clk api. Such clock names is
>> defined in variants specific data and needs to fetched during init.
> Why not just get all the clks and not even care about the names of them?
> Use devm_clk_bulk_get_all() for that, unless some clks need to change
> rates?

There is ahbix clk which needs clk rate to be set. Please check below 
patch in

the series for reference

[PATCH v5 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform 
specific function

Thanks,

Rohit

-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.


  reply	other threads:[~2020-08-06  4:01 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 10:31 [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant Rohit kumar
2020-07-22 10:31 ` [PATCH v4 01/12] ASoC: qcom: Add common array to initialize soc based core clocks Rohit kumar
2020-07-22 10:31   ` Rohit kumar
2020-08-06  0:31   ` Stephen Boyd
2020-08-06  0:31     ` Stephen Boyd
2020-08-06  3:59     ` Rohit Kumar [this message]
2020-08-07 20:17       ` Stephen Boyd
2020-07-22 10:31 ` [PATCH v4 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function Rohit kumar
2020-07-22 10:31 ` [PATCH v4 03/12] ASoC: qcom: lpass-platform: Replace card->dev with component->dev Rohit kumar
2020-07-22 10:31   ` Rohit kumar
2020-07-22 10:31 ` [PATCH v4 04/12] ASoC: qcom: lpass-platform: fix memory leak Rohit kumar
2020-07-24 11:21   ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 05/12] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers Rohit kumar
2020-07-22 10:31 ` [PATCH v4 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue Rohit kumar
2020-07-24 11:21   ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node Rohit kumar
2020-07-23 17:10   ` Rob Herring
2020-07-23 17:10     ` Rob Herring
2020-07-22 10:31 ` [PATCH v4 08/12] include: dt-bindings: sound: Add sc7180-lpass bindings header Rohit kumar
2020-07-22 10:31   ` Rohit kumar
2020-07-23 17:11   ` Rob Herring
2020-07-23 17:11     ` Rob Herring
2020-07-22 10:31 ` [PATCH v4 09/12] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar
2020-07-22 10:31   ` Rohit kumar
2020-07-22 10:31 ` [PATCH v4 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource Rohit kumar
2020-07-24 11:22   ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 11/12] ASoC: qcom: lpass-platform: Use platform_get_irq Rohit kumar
2020-07-22 10:31 ` [PATCH v4 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format Rohit kumar
2020-07-23 17:16   ` Rob Herring
2020-07-23 17:16     ` Rob Herring
2020-08-03  8:28     ` Rohit Kumar
2020-08-03  8:28       ` Rohit Kumar
2020-08-03 18:22       ` Rob Herring
2020-08-03 18:22         ` Rob Herring
2020-08-05  3:32         ` Rohit Kumar
2020-08-05  3:32           ` Rohit Kumar
2020-07-24 11:22 ` [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant Srinivas Kandagatla
2020-07-27  9:50   ` Rohit Kumar
2020-07-28 11:43     ` Rohit Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=989f1d99-3cd0-e725-3f6d-43facf1ec04d@codeaurora.org \
    --to=rohitkr@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=ajitp@codeaurora.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.