From: "Morten Brørup" <mb@smartsharesystems.com>
To: "changfengnan" <changfengnan@bytedance.com>,
<olivier.matz@6wind.com>, <andrew.rybchenko@oktetlabs.ru>,
<dev@dpdk.org>
Subject: RE: [PATCH] mempool: fix rte_mempool_avail_count may segment fault when used in multiprocess
Date: Mon, 14 Nov 2022 10:55:18 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D874B9@smartserver.smartshare.dk> (raw)
In-Reply-To: <20221114071439.38902-1-changfengnan@bytedance.com>
> From: changfengnan [mailto:changfengnan@bytedance.com]
> Sent: Monday, 14 November 2022 08.15
>
> rte_mempool_create put tailq entry into rte_mempool_tailq list before
> populate, and pool_data set when populate. So in multi process, if
> process A create mempool, and process B can get mempool through
> rte_mempool_lookup before pool_data set, if B call rte_mempool_lookup,
> it will cause segment fault.
> Fix this by put tailq entry into rte_mempool_tailq after populate.
>
> Signed-off-by: changfengnan <changfengnan@bytedance.com>
> ---
Good catch.
You must use your real name (not your username) before the email address in the sign-off line, or the patch cannot be accepted. Please refer to: https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body
With a proper sign-off line,
Acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2022-11-14 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 7:14 [PATCH] mempool: fix rte_mempool_avail_count may segment fault when used in multiprocess changfengnan
2022-11-14 9:55 ` Morten Brørup [this message]
2022-11-14 11:23 ` changfengnan
2022-11-14 20:43 ` David Marchand
2022-11-15 1:51 ` [External] " Fengnan Chang
2022-11-15 7:23 ` Morten Brørup
2022-11-15 7:47 ` David Marchand
2022-11-15 8:29 ` Olivier Matz
2022-11-15 11:30 ` Fengnan Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D874B9@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=changfengnan@bytedance.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.