From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, "Nicolas Chautru" <nicolas.chautru@intel.com>,
"Gagandeep Singh" <g.singh@nxp.com>,
"Hemant Agrawal" <hemant.agrawal@nxp.com>,
"Parav Pandit" <parav@nvidia.com>,
"Xueming Li" <xuemingl@nvidia.com>,
"Nipun Gupta" <nipun.gupta@amd.com>,
"Nikhil Agarwal" <nikhil.agarwal@amd.com>,
"Sachin Saxena" <sachin.saxena@nxp.com>,
"Rosen Xu" <rosen.xu@intel.com>,
"Tomasz Duszynski" <tduszynski@marvell.com>,
"Chengwen Feng" <fengchengwen@huawei.com>,
"Long Li" <longli@microsoft.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Kiran Kumar K" <kirankumark@marvell.com>,
"Sunil Kumar Kori" <skori@marvell.com>,
"Satha Rao" <skoteshwar@marvell.com>,
"Harman Kalra" <hkalra@marvell.com>,
"Jingjing Wu" <jingjing.wu@intel.com>,
"Nagadheeraj Rottela" <rnagadheeraj@marvell.com>,
"Srikanth Jampala" <jsrikanth@marvell.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Lee Daly" <lee.daly@intel.com>,
"Pablo de Lara" <pablo.de.lara.guarch@intel.com>,
"Fan Zhang" <fanzhang.oss@gmail.com>,
"Ashish Gupta" <ashish.gupta@marvell.com>,
"Sunila Sahu" <ssahu@marvell.com>,
"Ruifeng Wang" <ruifeng.wang@arm.com>,
"Liron Himi" <lironh@marvell.com>, "Kai Ji" <kai.ji@intel.com>,
"Anoob Joseph" <anoobj@marvell.com>,
"Zhangfei Gao" <zhangfei.gao@linaro.org>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Kevin Laatz" <kevin.laatz@intel.com>,
"Conor Walsh" <conor.walsh@intel.com>,
"Abdullah Sevincer" <abdullah.sevincer@intel.com>,
"Jerin Jacob" <jerinj@marvell.com>,
"Harry van Haaren" <harry.van.haaren@intel.com>,
"Elena Agostini" <eagostini@nvidia.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Ciara Loftus" <ciara.loftus@intel.com>,
"Shepard Siegel" <shepard.siegel@atomicrules.com>,
"Ed Czeck" <ed.czeck@atomicrules.com>,
"John Miller" <john.miller@atomicrules.com>,
"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>,
"Apeksha Gupta" <apeksha.gupta@nxp.com>,
"John Daley" <johndale@cisco.com>,
"Hyong Youb Kim" <hyonkim@cisco.com>,
"Ziyang Xuan" <xuanziyang2@huawei.com>,
"Xiaoyun Wang" <cloud.wangxiaoyun@huawei.com>,
"Andrew Boyer" <andrew.boyer@amd.com>,
"Jakub Grajciar" <jgrajcia@cisco.com>,
"Zyta Szpak" <zr@semihalf.com>,
"Martin Spinler" <spinler@cesnet.cz>,
"Tetsuya Mukawa" <mtetsuyah@gmail.com>,
"Vamsi Attunuru" <vattunuru@marvell.com>,
"Cristian Dumitrescu" <cristian.dumitrescu@intel.com>,
"Matan Azrad" <matan@nvidia.com>,
"Maxime Coquelin" <maxime.coquelin@redhat.com>,
"Chenbo Xia" <chenbox@nvidia.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Akhil Goyal" <gakhil@marvell.com>,
"Byron Marohn" <byron.marohn@intel.com>,
"Yipeng Wang" <yipeng1.wang@intel.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>,
"Zhirun Yan" <yanzhirun_163@163.com>,
"Sameh Gobriel" <sameh.gobriel@intel.com>,
"Reshma Pattan" <reshma.pattan@intel.com>,
"Srikanth Yalavarthi" <syalavarthi@marvell.com>,
"Jasvinder Singh" <jasvinder.singh@intel.com>,
"Pavan Nikhilesh" <pbhagavatula@marvell.com>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"David Hunt" <david.hunt@intel.com>,
"Sivaprasad Tummala" <sivaprasad.tummala@amd.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
"Ori Kam" <orika@nvidia.com>,
"Volodymyr Fialko" <vfialko@marvell.com>,
"Ciara Power" <ciara.power@intel.com>
Subject: RE: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT
Date: Mon, 22 Apr 2024 18:32:41 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F3D9@smartserver.smartshare.dk> (raw)
In-Reply-To: <20240422092003.425c9138@hermes.local>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Monday, 22 April 2024 18.20
>
> On Mon, 22 Apr 2024 17:24:43 +0200
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > #define RTE_LOG_REGISTER_IMPL(type, name, level) \
> > - int type; \
> > + extern int type; \
> > RTE_INIT(__##type) \
> > { \
> > type = rte_log_register_type_and_pick_level(name,
> RTE_LOG_##level); \
> > if (type < 0)
> \
> > type = RTE_LOGTYPE_EAL;
> \
> > } \
> > + int type
>
>
> Not all logtypes can/should be extern.
Creativity just kicked in:
#define RTE_LOG_REGISTER_IMPL(type, name, level) \
int type; \
RTE_INIT(__##type) \
{ \
type = rte_log_register_type_and_pick_level(name, RTE_LOG_##level); \
if (type < 0) \
type = RTE_LOGTYPE_EAL; \
} \
+ static_assert(1 == 1, "Dummy for semicolon.")
prev parent reply other threads:[~2024-04-22 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 0:08 [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT Stephen Hemminger
2024-04-20 7:48 ` Morten Brørup
2024-04-22 15:13 ` Stephen Hemminger
2024-04-22 15:24 ` Morten Brørup
2024-04-22 16:20 ` Stephen Hemminger
2024-04-22 16:32 ` Morten Brørup [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35E9F3D9@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=abdullah.sevincer@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.boyer@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=apeksha.gupta@nxp.com \
--cc=ashish.gupta@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=byron.marohn@intel.com \
--cc=chenbox@nvidia.com \
--cc=ciara.loftus@intel.com \
--cc=ciara.power@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=conor.walsh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=eagostini@nvidia.com \
--cc=ed.czeck@atomicrules.com \
--cc=fanzhang.oss@gmail.com \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=hyonkim@cisco.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinj@marvell.com \
--cc=jgrajcia@cisco.com \
--cc=jingjing.wu@intel.com \
--cc=john.miller@atomicrules.com \
--cc=johndale@cisco.com \
--cc=jsrikanth@marvell.com \
--cc=kai.ji@intel.com \
--cc=kevin.laatz@intel.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=lee.daly@intel.com \
--cc=linville@tuxdriver.com \
--cc=lironh@marvell.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=mtetsuyah@gmail.com \
--cc=ndabilpuram@marvell.com \
--cc=nicolas.chautru@intel.com \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=orika@nvidia.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=parav@nvidia.com \
--cc=pbhagavatula@marvell.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=reshma.pattan@intel.com \
--cc=rnagadheeraj@marvell.com \
--cc=rosen.xu@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=sachin.saxena@nxp.com \
--cc=sameh.gobriel@intel.com \
--cc=shepard.siegel@atomicrules.com \
--cc=sivaprasad.tummala@amd.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=spinler@cesnet.cz \
--cc=ssahu@marvell.com \
--cc=stephen@networkplumber.org \
--cc=syalavarthi@marvell.com \
--cc=tduszynski@marvell.com \
--cc=thomas@monjalon.net \
--cc=vattunuru@marvell.com \
--cc=vfialko@marvell.com \
--cc=vladimir.medvedkin@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=xuemingl@nvidia.com \
--cc=yanzhirun_163@163.com \
--cc=yipeng1.wang@intel.com \
--cc=zhangfei.gao@linaro.org \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.