From: Julia Filipchuk <julia.filipchuk@intel.com>
To: Zhanjun Dong <zhanjun.dong@intel.com>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v7 3/6] drm/xe/guc: Add GuC log init config in LFD format
Date: Mon, 20 Oct 2025 16:44:22 -0700 [thread overview]
Message-ID: <98cbe993-463d-448b-8c76-7b109d008673@intel.com> (raw)
In-Reply-To: <20250828174159.1232994-4-zhanjun.dong@intel.com>
> +/* Magic keys define */
> +#define GUC_LFD_DRIVER_KEY_STREAMING 0x8086AAAA474C5346
> +#define GUC_LFD_LOG_BUFFER_MARKER_2 0xDEADFEED
> +#define GUC_LFD_CRASH_DUMP_BUFFER_MARKER_2 0x8086DEAD
> +#define GUC_LFD_STATE_CAPTURE_BUFFER_MARKER_2 0xBEEFFEED
> +#define GUC_LFD_LOG_BUFFER_MARKER_1V2 0xCABBA9E6
> +#define GUC_LFD_STATE_CAPTURE_BUFFER_MARKER_1V2 0xCABBA9F7
> +#define GUC_LFD_DATA_HEADER_MAGIC 0x8086
Possibly fix alignment
> +/* LFD supported LIC type range */
> +#define GUC_LIC_TYPE_FIRST GUC_LIC_TYPE_GUC_SW_VERSION
> +#define GUC_LIC_TYPE_LAST GUC_LIC_TYPE_BUILD_PLATFORM_ID
> +#define GUC_LFD_TYPE_FW_RANGE_FIRST GUC_LFD_TYPE_FW_VERSION
> +#define GUC_LFD_TYPE_FW_RANGE_LAST GUC_LFD_TYPE_BUILD_PLATFORM_ID
Does it make sense to define these near the relevant enums?
> +
> +void
> +xe_guc_log_snapshot_print_lfd(struct xe_guc_log_snapshot *snapshot, struct drm_printer *p);
> +void
> +xe_guc_log_snapshot_print_lfd(struct xe_guc_log_snapshot *snapshot, struct drm_printer *p)
Should this just be declared static?
next prev parent reply other threads:[~2025-10-20 23:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 17:41 [PATCH v7 0/6] drm/xe/guc: Add LFD format output for guc log Zhanjun Dong
2025-08-28 17:41 ` [PATCH v7 1/6] drm/xe/guc: Add log init config abi definitions Zhanjun Dong
2025-10-09 11:49 ` Michal Wajdeczko
2025-10-20 23:11 ` Julia Filipchuk
2025-08-28 17:41 ` [PATCH v7 2/6] drm/xe/guc: Add LFD related " Zhanjun Dong
2025-10-20 23:11 ` Julia Filipchuk
2025-08-28 17:41 ` [PATCH v7 3/6] drm/xe/guc: Add GuC log init config in LFD format Zhanjun Dong
2025-10-20 23:44 ` Julia Filipchuk [this message]
2025-11-25 18:19 ` Dong, Zhanjun
2025-11-25 19:47 ` Julia Filipchuk
2025-08-28 17:41 ` [PATCH v7 4/6] drm/xe/guc: Add GuC log event buffer output " Zhanjun Dong
2025-10-20 23:36 ` Julia Filipchuk
2025-11-26 23:05 ` Dong, Zhanjun
2025-08-28 17:41 ` [PATCH v7 5/6] drm/xe/guc: Only add GuC crash dump if available Zhanjun Dong
2025-10-20 23:11 ` Julia Filipchuk
2025-11-26 22:59 ` Dong, Zhanjun
2025-08-28 17:41 ` [PATCH v7 6/6] drm/xe/guc: Add new debugfs entry for lfd format output Zhanjun Dong
2025-10-20 23:12 ` Julia Filipchuk
2025-08-28 19:17 ` ✗ CI.checkpatch: warning for drm/xe/guc: Add LFD format output for guc log (rev7) Patchwork
2025-08-28 19:19 ` ✓ CI.KUnit: success " Patchwork
2025-08-28 19:56 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-29 3:03 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98cbe993-463d-448b-8c76-7b109d008673@intel.com \
--to=julia.filipchuk@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.