Re: [PATCH v3 2/2] drm/amdgpu/gem: use dma_resv_add_fence directly

["Christian König" <christian.koenig@amd.com>]

On 11/9/26 15:57, Benjamin Cheng wrote:
> Christian pointed out that amdgpu_bo_fence() is deprecated since it
> reserves fence slots there outside of the lock. Replace it with a direct
> dma_resv_add_fence call here (we reserve the correct amount of fences
> already). Also switch it to use the BOOKKEEP usage since these are both
> kernel-internal fences.
> 
> Signed-off-by: Benjamin Cheng <benjamin.cheng@amd.com>

Oh changing that to BOOKKEEP is a really good idea. Are there still users of amdgpu_bo_fence() left?

Either way Reviewed-by: Christian König <christian.koenig@amd.com> for both patches.

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index c9a84257ae5f..eebba3bea089 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -373,11 +373,11 @@ static void amdgpu_gem_object_close(struct drm_gem_object *obj,
>  	if (r || !fence)
>  		goto out_tlb;
>  
> -	amdgpu_bo_fence(bo, fence, true);
> +	dma_resv_add_fence(bo->tbo.base.resv, fence, DMA_RESV_USAGE_BOOKKEEP);
>  	dma_fence_put(fence);
>  
>  out_tlb:
> -	amdgpu_bo_fence(bo, vm->last_tlb_inv, true);
> +	dma_resv_add_fence(bo->tbo.base.resv, vm->last_tlb_inv, DMA_RESV_USAGE_BOOKKEEP);
>  
>  out_unlock:
>  	if (r && !drm_dev_is_unplugged(adev_to_drm(adev)))