All of lore.kernel.org
 help / color / mirror / Atom feed
From: "WHR" <whr@rivoreo.one>
To: u-boot@lists.denx.de
Cc: "Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Simon Glass" <sjg@chromium.org>, "Tom Rini" <trini@konsulko.com>
Subject: [PATCH v3] sandbox: make function 'do_undefined' properly compiles for PowerPC
Date: Wed, 1 May 2024 00:55:10 +0800	[thread overview]
Message-ID: <98e71d2cd17cd9992e60190ede4a5b03.squirrel@_> (raw)

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

The 2 bytes 0xffff is too short for being a PowerPC instruction, resulting
in an error similar to:
    /tmp/ccW8yjie.s: Assembler messages:
    /tmp/ccW8yjie.s: Error: unaligned opcodes detected in executable segment
    /tmp/ccW8yjie.s:223: Error: instruction address is not a multiple of 4 
    make[2]: *** [/tmp/ccyF4HIC.mk:17: /tmp/ccCKUFuF.ltrans5.ltrans.o] Error 1

Signed-off-by: WHR <msl0000023508@gmail.com>

---
v2:
Resubmit with diff content in plain text.
v3:
Reformat commit message body that was previously mangled by my email client.

 cmd/sandbox/exception.c | 4 ++++
 1 file changed, 4 insertions(+)


[-- Attachment #2: 0001-sandbox-make-function-do_undefined-properly-compiles --]
[-- Type: text/plain, Size: 477 bytes --]

diff --git a/cmd/sandbox/exception.c b/cmd/sandbox/exception.c
index cfa153da26..f9c847d8ff 100644
--- a/cmd/sandbox/exception.c
+++ b/cmd/sandbox/exception.c
@@ -19,7 +19,11 @@ static int do_sigsegv(struct cmd_tbl *cmdtp, int flag, int argc,
 static int do_undefined(struct cmd_tbl *cmdtp, int flag, int argc,
 			char *const argv[])
 {
+#ifdef __powerpc__
+	asm volatile (".long 0xffffffff\n");
+#else
 	asm volatile (".word 0xffff\n");
+#endif
 	return CMD_RET_FAILURE;
 }
 

             reply	other threads:[~2024-04-30 16:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 16:55 WHR [this message]
2024-05-14 16:15 ` [PATCH v3] sandbox: make function 'do_undefined' properly compiles for PowerPC Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98e71d2cd17cd9992e60190ede4a5b03.squirrel@_ \
    --to=whr@rivoreo.one \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.