From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268F2C38A30 for ; Mon, 20 Apr 2020 18:11:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C68621D79 for ; Mon, 20 Apr 2020 18:11:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="mSs/GQYq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbgDTSLD (ORCPT ); Mon, 20 Apr 2020 14:11:03 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:52544 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726532AbgDTSLC (ORCPT ); Mon, 20 Apr 2020 14:11:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587406262; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=wos3Ak73xOXHzWR83+yksTYRpe5mwIS/buxq9eAwCz8=; b=mSs/GQYqfZToWyRP3JWD5mtfnYir3UpV0jNX1KGZ3Mx6tKvcIl1W5LoWebKmXY69qC3QFknz CP8gSyCQE56e6VGk4gLFdtQiRtlkTulnpIWKFKqfSlFw5wN3oxGm9NKKHdwSc6uLVDHDznnp hpTzmmd6lFqK7hMP4TRCswPKCLY= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e9de5a5.7f8e56643570-smtp-out-n04; Mon, 20 Apr 2020 18:10:45 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DB666C433F2; Mon, 20 Apr 2020 18:10:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5DCECC433D2; Mon, 20 Apr 2020 18:10:42 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 20 Apr 2020 23:40:42 +0530 From: Sai Prakash Ranjan To: Robin Murphy Cc: Will Deacon , Joerg Roedel , Sibi Sankar , Bjorn Andersson , Jordan Crouse , Rob Clark , Stephen Boyd , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Matthias Kaehlcke , Evan Green Subject: Re: [PATCHv3 4/6] iommu/arm-smmu-qcom: Request direct mapping for modem device In-Reply-To: <49c8c377-961b-3f95-a99c-08528def4cb7@arm.com> References: <509d88fbe7592aa15f867933c177b61bc7ba8efa.1587400573.git.saiprakash.ranjan@codeaurora.org> <49c8c377-961b-3f95-a99c-08528def4cb7@arm.com> Message-ID: <98fa2940456ade2bd0998dfaa6386653@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Robin, On 2020-04-20 22:39, Robin Murphy wrote: > On 2020-04-20 5:42 pm, Sai Prakash Ranjan wrote: >> From: Sibi Sankar >> >> Request direct mapping for modem on platforms which don't have >> TrustZone >> (which programs the modem SIDs) to prevent the following global faults >> seen >> on Cheza/Trogdor: > > Not strictly true - it's patch #6/6 that prevents *those* faults (and > these days the driver should be reporting unmatched streams a little > more helpfully). This change would resolve the context faults and/or > weird memory corruption that might result from applying patch #6 alone > - this is the crazy thing where transactions sometimes go directly to > DRAM round the side of the SMMU so we can never safely remap anything, > right? > True this doesnt prevent global faults, the fault details should go to patch6. I'll update the commit msg something like below: The Q6 modem sub-system has direct access to DDR through memnoc. Also SMMU is not expected to provide access control/translation for these SIDs (sandboxing of the modem is achieved through XPUs engaged using SMC calls). Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63A3C3815B for ; Mon, 20 Apr 2020 18:10:55 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEDCF2071C for ; Mon, 20 Apr 2020 18:10:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="skKKXCwI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEDCF2071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 7F4A32083F; Mon, 20 Apr 2020 18:10:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zgOSkTVqNXLw; Mon, 20 Apr 2020 18:10:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id B57D2203C8; Mon, 20 Apr 2020 18:10:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 98E21C07FF; Mon, 20 Apr 2020 18:10:54 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B980EC0177 for ; Mon, 20 Apr 2020 18:10:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A876C86D13 for ; Mon, 20 Apr 2020 18:10:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qi3AZ50M2DJg for ; Mon, 20 Apr 2020 18:10:51 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail26.static.mailgun.info (mail26.static.mailgun.info [104.130.122.26]) by whitealder.osuosl.org (Postfix) with ESMTPS id AD294838CD for ; Mon, 20 Apr 2020 18:10:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587406251; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=wos3Ak73xOXHzWR83+yksTYRpe5mwIS/buxq9eAwCz8=; b=skKKXCwIIq7FtHwZW7dWvfYo+IUVz3bi2X9WhQWPy5Nc91+e2ba4dsJzS2DCwYep81GbuXgJ 3SOki5nNa6CTkCwALQYtDq89Lm2CYKvK5t76iAXFLZ9GTGjwFfN65SKFKjSsjH0y8un6KEC7 6AnsmdbUgsOCsbPTvLz+JoRXM50= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3NDkwMCIsICJpb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e9de5a4.7ff15caf0c00-smtp-out-n02; Mon, 20 Apr 2020 18:10:44 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BECADC43637; Mon, 20 Apr 2020 18:10:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5DCECC433D2; Mon, 20 Apr 2020 18:10:42 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 20 Apr 2020 23:40:42 +0530 From: Sai Prakash Ranjan To: Robin Murphy Subject: Re: [PATCHv3 4/6] iommu/arm-smmu-qcom: Request direct mapping for modem device In-Reply-To: <49c8c377-961b-3f95-a99c-08528def4cb7@arm.com> References: <509d88fbe7592aa15f867933c177b61bc7ba8efa.1587400573.git.saiprakash.ranjan@codeaurora.org> <49c8c377-961b-3f95-a99c-08528def4cb7@arm.com> Message-ID: <98fa2940456ade2bd0998dfaa6386653@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Cc: Evan Green , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Bjorn Andersson , Matthias Kaehlcke , Sibi Sankar , linux-arm-msm@vger.kernel.org, Stephen Boyd , Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Robin, On 2020-04-20 22:39, Robin Murphy wrote: > On 2020-04-20 5:42 pm, Sai Prakash Ranjan wrote: >> From: Sibi Sankar >> >> Request direct mapping for modem on platforms which don't have >> TrustZone >> (which programs the modem SIDs) to prevent the following global faults >> seen >> on Cheza/Trogdor: > > Not strictly true - it's patch #6/6 that prevents *those* faults (and > these days the driver should be reporting unmatched streams a little > more helpfully). This change would resolve the context faults and/or > weird memory corruption that might result from applying patch #6 alone > - this is the crazy thing where transactions sometimes go directly to > DRAM round the side of the SMMU so we can never safely remap anything, > right? > True this doesnt prevent global faults, the fault details should go to patch6. I'll update the commit msg something like below: The Q6 modem sub-system has direct access to DDR through memnoc. Also SMMU is not expected to provide access control/translation for these SIDs (sandboxing of the modem is achieved through XPUs engaged using SMC calls). Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF7CFC3815B for ; Mon, 20 Apr 2020 18:12:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A55FF2074F for ; Mon, 20 Apr 2020 18:12:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IQ4+VOYO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="KIRJV3AG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A55FF2074F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0vrnr+m2lelvMYhmiQ7CU7mTeh4DcO6eH/axjdsRvgo=; b=IQ4+VOYOQaMXtFKlvd8MzTdHA jR4Y9VfL2kPImzNlHIQs1ecRjWEDo/f1IYSTqb2ZNP3+FK8I/w8GntYA07+4lRknPGTvmDhRmZ/dE CsndCpCWDOxKCwHd5NHTkgah/R61CxE2y2PaE6zpR0LqqL9ehuIlmraQcS1H+w4mUfRp1E9Rey9Ia 9F2a1+P61Iv2TPsEeT2qHAujxA28mrHzXqjassf8mTainVWGjtpQG3M3fdZyTZfxpsFvnTTiQuGlB Xb66QeMKTcsETwsy/5+MlUpgtrB532F8tmnpM5TJGBEmx3ilhT/QS/w81vXnN+lMgfaFuEgv2bN67 d7L4PdS+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQatp-00048R-Tr; Mon, 20 Apr 2020 18:12:05 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQask-0003uV-9z for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2020 18:11:06 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587406259; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=wos3Ak73xOXHzWR83+yksTYRpe5mwIS/buxq9eAwCz8=; b=KIRJV3AG0OwUiMU9kUTEux+IqTdRIvXs7SHX04WJI6HRRO46ncfrzv0RdvAvoUcC0UwyWAYT cysyB4yWXH3zwIk280qUlckdI0OrKsadPAbC+E3YJJ4gJMe2wYGCR6XiF6KpjGKA3XoWNhVx Z2nbDZklbWh6j2VuJWvbbmg3Q4E= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e9de5a4.7f04e308ac38-smtp-out-n02; Mon, 20 Apr 2020 18:10:44 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 41B4FC44788; Mon, 20 Apr 2020 18:10:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5DCECC433D2; Mon, 20 Apr 2020 18:10:42 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 20 Apr 2020 23:40:42 +0530 From: Sai Prakash Ranjan To: Robin Murphy Subject: Re: [PATCHv3 4/6] iommu/arm-smmu-qcom: Request direct mapping for modem device In-Reply-To: <49c8c377-961b-3f95-a99c-08528def4cb7@arm.com> References: <509d88fbe7592aa15f867933c177b61bc7ba8efa.1587400573.git.saiprakash.ranjan@codeaurora.org> <49c8c377-961b-3f95-a99c-08528def4cb7@arm.com> Message-ID: <98fa2940456ade2bd0998dfaa6386653@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200420_111104_947530_C029485E X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Evan Green , linux-kernel@vger.kernel.org, Joerg Roedel , Jordan Crouse , iommu@lists.linux-foundation.org, Bjorn Andersson , Rob Clark , Matthias Kaehlcke , Sibi Sankar , linux-arm-msm@vger.kernel.org, Stephen Boyd , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, On 2020-04-20 22:39, Robin Murphy wrote: > On 2020-04-20 5:42 pm, Sai Prakash Ranjan wrote: >> From: Sibi Sankar >> >> Request direct mapping for modem on platforms which don't have >> TrustZone >> (which programs the modem SIDs) to prevent the following global faults >> seen >> on Cheza/Trogdor: > > Not strictly true - it's patch #6/6 that prevents *those* faults (and > these days the driver should be reporting unmatched streams a little > more helpfully). This change would resolve the context faults and/or > weird memory corruption that might result from applying patch #6 alone > - this is the crazy thing where transactions sometimes go directly to > DRAM round the side of the SMMU so we can never safely remap anything, > right? > True this doesnt prevent global faults, the fault details should go to patch6. I'll update the commit msg something like below: The Q6 modem sub-system has direct access to DDR through memnoc. Also SMMU is not expected to provide access control/translation for these SIDs (sandboxing of the modem is achieved through XPUs engaged using SMC calls). Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel