From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:3657:b0:a0d:e0d9:b5bf with SMTP id r23csp2467969ejb; Sun, 3 Dec 2023 20:45:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTr4zvKGVD3DEIOEGmxaaM50m6Y/VsU7V7o+pP7yu4zpmL3sn/h7sU2L3caGa8aJOOAEe7 X-Received: by 2002:a05:6214:5008:b0:67a:2df0:3ce1 with SMTP id jo8-20020a056214500800b0067a2df03ce1mr4417224qvb.41.1701665148323; Sun, 03 Dec 2023 20:45:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701665148; cv=none; d=google.com; s=arc-20160816; b=nACR/HIKdWtbkHu0ofDXFM3OY3qZkdVx20cPQVzS/gRZuscbW7RJBYuQoTbFVaPe6w uPjSfKD2gXTlT6DU3c06B8MA2yOW8RiqIVpo7pU9vAzjez6idaJwYc+RhxRc7HazhlWu 0iA4Ue5IrYWRiN04BiQzByHJgG4c51YZoHyf6znR2KaeKsSL0om7wHN3sRWNOgEKAsY0 46/9DxQB/GV0YpvY0zjau8i83vzhCLM+KAWVRoAUp3pqHx/O8zOAQqAxie4IOMq3z+VA gfJ/l6wO3pXiwA7lyPbGm6/QtIkP1b/Q7pl7Y3zlfgduxQ0QyrfZkXRKn5i5RYnLbHqw QaaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=bb0tykILfPLEILdRE8hVCumwIs1g9/yBXuZq77yrMVI=; fh=7ioxn6LWsCzgGR12WMVU/wASROmAygH/3PvRDFKIzPw=; b=tzUSgy9yMNhf8X8XD7nYLcA9nkxot6EGlHh3jQmzMEpWfzfLteBxsjEts/tVIJ95qC RHM2inL3qzmpjQ2YuiLbl2c8uBY95wcNTOF9/wmPwdiliRBWOkGdT0PQ80lR+NG3WptS tdStaHbYwhLVszgzOnS58YHZaDw38cJkMUUpTNSRbfl+vwhuz6bQ+6G6K212wQkAVuHK PxCh91YexS4ioG1ojUgwLgndrM8T2cIS05hSE2k+IK2ACJSbkoNg9/iIrNJNz8YbXFS3 H5XOKEsCiphWXbh7tiMrh9JAE39THvShbNHwlcHBUKkp57HrF+2AGqY6cE/BC59Q9sgR 9v6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OGX30Bke; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id lb24-20020a056214319800b0067abb355e20si2878861qvb.336.2023.12.03.20.45.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Dec 2023 20:45:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OGX30Bke; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rA0pt-0005Ku-IN; Sun, 03 Dec 2023 23:45:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rA0pb-0005Jk-5l for qemu-devel@nongnu.org; Sun, 03 Dec 2023 23:45:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rA0pZ-0008Mb-2v for qemu-devel@nongnu.org; Sun, 03 Dec 2023 23:45:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701665116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bb0tykILfPLEILdRE8hVCumwIs1g9/yBXuZq77yrMVI=; b=OGX30BkesO9EOEQmZM4iScUq/rnxPqJBhbytfAgA8WUY97vJv35Yj/OJuEXnJ/CHRNqeFz x/przv/ZGbASqZ0bS8BwFvBNYbt9SKn76tFkwlFpRNukzBFweCanYXbZ1zrdRbWy+20VVj gMIWn9uCQhOobBMPZfg8CX4I3P6aps0= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-24bx8An_PxifeSnt5xtcqA-1; Sun, 03 Dec 2023 23:45:14 -0500 X-MC-Unique: 24bx8An_PxifeSnt5xtcqA-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1d06b8d7982so9143875ad.2 for ; Sun, 03 Dec 2023 20:45:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701665113; x=1702269913; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bb0tykILfPLEILdRE8hVCumwIs1g9/yBXuZq77yrMVI=; b=XyVpzenxTVb1/9SIzw98AxLJZ5/9wUaA+GHHfM9jWf8xlHddis7/3SulCUVp6szjkg fpcC6oi2AYWdePmjG0iT+S94kE0XwqT4p3ibIo9VQIJjhNFlhS4+mB9GjXvhNboC1R3s wTHxL0S1GwPv9qKnF7YWNB7AeZuEss/hNLHRt1dhA4W883OGsq79kKGXQ5RY4WdFHg2m Jrzt/nrR9qdpTNS/4/xakBfonkvhXo+Zya+FLJ5nDm4gH8Kg715rGoX4ytjMboTv9Dpw coms+kK7E5dp+IdsouMmR6aUzl6QPDMtcHzMyywKmRHr51w0Y16QgqOhEhFHaN896BnB Qx6g== X-Gm-Message-State: AOJu0Yxh1h32PJgG01FrWNdgTE8g4ElpYlgjXPZKgJtoh/78Y4oGYa8H JL67mfs2e4LYkZg2Pw0pDPEfZ63rmPFKIEzdXMvWgmR1Hj7ruwnjXfY9iXgd8n8cdNrJk2TXR6Q m4IAjfY3FiZaJe1eiUVUDkDU= X-Received: by 2002:a17:903:2616:b0:1d0:60ce:be09 with SMTP id jd22-20020a170903261600b001d060cebe09mr3047401plb.61.1701665113298; Sun, 03 Dec 2023 20:45:13 -0800 (PST) X-Received: by 2002:a17:903:2616:b0:1d0:60ce:be09 with SMTP id jd22-20020a170903261600b001d060cebe09mr3047395plb.61.1701665113039; Sun, 03 Dec 2023 20:45:13 -0800 (PST) Received: from [192.168.68.51] ([43.252.115.3]) by smtp.gmail.com with ESMTPSA id h21-20020a170902f7d500b001d058ad8770sm5298193plw.306.2023.12.03.20.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Dec 2023 20:45:12 -0800 (PST) Message-ID: <99075540-364e-4d8a-bad9-eb52d50a129c@redhat.com> Date: Mon, 4 Dec 2023 14:45:07 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-9.0 03/25] memory: Have memory_region_init_rom_nomigrate() handler return a boolean Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: David Hildenbrand , Peter Maydell , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Mark Cave-Ayland , Markus Armbruster , Paolo Bonzini , Igor Mammedov , qemu-ppc@nongnu.org, =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Peter Xu References: <20231120213301.24349-1-philmd@linaro.org> <20231120213301.24349-4-philmd@linaro.org> From: Gavin Shan In-Reply-To: <20231120213301.24349-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: WYWL2EyBp/7Y On 11/21/23 07:32, Philippe Mathieu-Daudé wrote: > Following the example documented since commit e3fe3988d7 ("error: > Document Error API usage rules"), have cpu_exec_realizefn() > return a boolean indicating whether an error is set or not. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/exec/memory.h | 4 +++- > system/memory.c | 8 ++++++-- > 2 files changed, 9 insertions(+), 3 deletions(-) > s/cpu_exec_realizefn()/memory_region_init_rom_nomigrate() in the commit message, mentioned by Peter Xu. With this: Reviewed-by: Gavin Shan