From: Quentin Monnet <qmo@kernel.org>
To: Jiayuan Chen <jiayuan.chen@linux.dev>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykyta Yatsenko <yatsenko@meta.com>,
Daniel Xu <dxu@dxuuu.xyz>, Tao Chen <chen.dylane@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v3] bpftool: Add support for custom BTF path in prog load/loadall
Date: Fri, 16 May 2025 11:18:33 +0100 [thread overview]
Message-ID: <9909038f-a005-440a-82f2-ebe2f2da0767@kernel.org> (raw)
In-Reply-To: <20250516032312.275261-1-jiayuan.chen@linux.dev>
2025-05-16 11:23 UTC+0800 ~ Jiayuan Chen <jiayuan.chen@linux.dev>
> This patch exposes the btf_custom_path feature to bpftool, allowing users
> to specify a custom BTF file when loading BPF programs using prog load or
> prog loadall commands.
>
> The argument 'btf_custom_path' in libbpf is used for those kernels that
> don't have CONFIG_DEBUG_INFO_BTF enabled but still want to perform CO-RE
> relocations.
>
> Suggested-by: Quentin Monnet <qmo@kernel.org>
> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
>
> ---
> V2 -> V3: Optimized document grammar and some prompts
> https://lore.kernel.org/bpf/20250515065018.240188-1-jiayuan.chen@linux.dev/
> V1 -> V2: Added bash completion and documentation
> https://lore.kernel.org/bpf/20250513035853.75820-1-jiayuan.chen@linux.dev/
> ---
> tools/bpf/bpftool/Documentation/bpftool-prog.rst | 8 +++++++-
> tools/bpf/bpftool/bash-completion/bpftool | 4 ++--
> tools/bpf/bpftool/prog.c | 12 +++++++++++-
> 3 files changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/tools/bpf/bpftool/Documentation/bpftool-prog.rst b/tools/bpf/bpftool/Documentation/bpftool-prog.rst
> index d6304e01afe0..4dce43e8e8a3 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool-prog.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool-prog.rst
> @@ -127,7 +127,7 @@ bpftool prog pin *PROG* *FILE*
> Note: *FILE* must be located in *bpffs* mount. It must not contain a dot
> character ('.'), which is reserved for future extensions of *bpffs*.
>
> -bpftool prog { load | loadall } *OBJ* *PATH* [type *TYPE*] [map { idx *IDX* | name *NAME* } *MAP*] [{ offload_dev | xdpmeta_dev } *NAME*] [pinmaps *MAP_DIR*] [autoattach]
> +bpftool prog { load | loadall } *OBJ* *PATH* [type *TYPE*] [map { idx *IDX* | name *NAME* } *MAP*] [{ offload_dev | xdpmeta_dev } *NAME*] [pinmaps *MAP_DIR*] [autoattach] [kernel_btf *BTF_FILE*]
Woops, I just realised we also need to add kernel_btf to the command
summary at the top of the document (line 34), sorry for missing it
during the previous pass. Please add it, and mark v4 as:
Reviewed-by: Quentin Monnet <qmo@kernel.org>
Thanks!
next prev parent reply other threads:[~2025-05-16 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 3:23 [PATCH bpf-next v3] bpftool: Add support for custom BTF path in prog load/loadall Jiayuan Chen
2025-05-16 10:18 ` Quentin Monnet [this message]
2025-05-16 14:24 ` Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9909038f-a005-440a-82f2-ebe2f2da0767@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chen.dylane@gmail.com \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jiayuan.chen@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yatsenko@meta.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.