From: Helge Deller <Helge.Deller@ruhr-uni-bochum.de>
To: parisc-linux@thepuffingroup.com,
Alex deVries <adevries@thepuffingroup.com>,
frowand@cup.hp.com
Cc: Paul Bame <bame@debian.fc.hp.com>
Subject: Re: [parisc-linux] Boot messages from C3000 console
Date: Fri, 22 Oct 1999 17:15:02 +0200 [thread overview]
Message-ID: <99102217512801.00256@P100> (raw)
In-Reply-To: Pine.LNX.4.10.9910212221480.18206-100000@vodka.thepuffingroup.com
Am Fri, 22 Oct 1999 schrieb Alex deVries:
> On Thu, 21 Oct 1999, Frank Rowand wrote:
> > Ok, tirade mode off. This is where my newbie status becomes apparent. Please
> > excuse any foot in mouth here. I looked at the Puffin web page and didn't
> > notice anything about the process of making sure that code that is submitted
> > has some minimal level of quality. Is it just a matter of the community
> > applying peer pressure?
>
> In fact, it's *ALL* about the community applying pressure.
>
> If the code in head.S is a bit rough, remember that it was just about the
> first PA-RISC assembler that Helge or Philipp had ever written, so do keep
> that in mind. Also, at the start of the project, there was a very
> conscious effort to only be concerned with 1.1 code. It doesn't surprise
> me in the least that it's not 2.0 compliant.
>
> I agree that the code is unreadable though; I've simply passed it off on
> not being able to understand parisc assembler well enough.
>
> We'd all appreciate it if you could commit appropriate changes to make the
> code clearer.
>
> - Alex
Thanks Alex,
Yes, we all know that the boot-loader really needs a complete clean-up, and as
it looks like I´m the maintainer of the bootloader.
It´s really funny to see people from HP talking to the list and saying somthing
about code-quality, but only as a little reminder:
When I wrote the bootloader I had no documentation on bootloading from HP at
all, no knowledge of parisc and got it only working with trial & error methods
in day and night-sessions. More, it´s first goal was to get at least a kernel
booted so that the real kernel-development could start. (See my messages in the
commits) The end of this all was this really ugly bootloader with many until
now unused enhancements (ELF-loader and ramdisk-support) which can be easily
removed.
More I think there are currently MUCH MORE IMPORTANT things to be fixed in the
kernel than beautifying a (mostly) working bootloader which will be completely
rewritten in the future. When time has come and we have clean code to read
filesystems like LIF and HFS, then this can be easily integrated into a
completely rewritten PALO (PArisc-LOader).
But currently I have nearly no time at all (as many others on this list), so if
anyone has time to fix things, beautify the code and send me patches or
enhancements I really would like to integrate them at once.
SO: PLEASE don´t talk about quality of source code (we all know, that the
bootloader is bad!) , just send patches !!!!!
NB: It seems, that many people wants to talk about this over and over again.
All this was already said some weeks ago.....
Helge Deller.
next prev parent reply other threads:[~1999-10-22 15:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-21 19:57 [parisc-linux] Boot messages from C3000 console Paul Bame
1999-10-21 21:24 ` Stan Sieler
1999-10-21 22:05 ` Frank Rowand
1999-10-21 22:51 ` Grant Grundler
1999-10-22 0:57 ` Frank Rowand
1999-10-22 2:23 ` Jason Eckhardt
1999-10-22 2:33 ` Alex deVries
1999-10-22 15:15 ` Helge Deller [this message]
1999-10-22 17:32 ` Frank Rowand
1999-10-22 23:42 ` Philipp Rumpf
1999-10-23 3:46 ` Ryan Bradetich
1999-10-22 22:16 ` Philipp Rumpf
1999-10-22 16:06 ` Grant Grundler
1999-10-24 3:44 ` [parisc-linux] Trying to boot on an N-Class Justin Hamilton
1999-10-24 5:22 ` Grant Grundler
1999-10-24 8:43 ` Philipp Rumpf
1999-10-22 22:14 ` [parisc-linux] Boot messages from C3000 console Philipp Rumpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99102217512801.00256@P100 \
--to=helge.deller@ruhr-uni-bochum.de \
--cc=adevries@thepuffingroup.com \
--cc=bame@debian.fc.hp.com \
--cc=frowand@cup.hp.com \
--cc=parisc-linux@thepuffingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.