From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 04/11] iommu/omap: Protect omap-iopgtable.h against double inclusion
Date: Tue, 21 Jul 2015 19:01:22 +0300 [thread overview]
Message-ID: <9915916.m7jlAc5up8@avalon> (raw)
In-Reply-To: <1437431613-55656-5-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
Hi Suman,
Thank you for the patch.
On Monday 20 July 2015 17:33:26 Suman Anna wrote:
> Protect the omap-pgtable.h header against double inclusion in
> source code by using the standard include guard mechanism.
>
> Signed-off-by: Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> ---
> drivers/iommu/omap-iopgtable.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/iommu/omap-iopgtable.h b/drivers/iommu/omap-iopgtable.h
> index f891683e3f05..bfde5405f514 100644
> --- a/drivers/iommu/omap-iopgtable.h
> +++ b/drivers/iommu/omap-iopgtable.h
> @@ -10,6 +10,9 @@
> * published by the Free Software Foundation.
> */
>
> +#ifndef _OMAP_IOPGTABLE_H
> +#define _OMAP_IOPGTABLE_H
> +
> /*
> * "L2 table" address mask and size definitions.
> */
> @@ -93,3 +96,5 @@ static inline phys_addr_t omap_iommu_translate(u32 d, u32
> va, u32 mask) /* to find an entry in the second-level page table. */
> #define iopte_index(da) (((da) >> IOPTE_SHIFT) & (PTRS_PER_IOPTE - 1))
> #define iopte_offset(iopgd, da) (iopgd_page_vaddr(iopgd) +
iopte_index(da))
> +
> +#endif /* _OMAP_IOPGTABLE_H */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-07-21 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 22:33 [PATCH 00/11] Some OMAP IOMMU cleanup patches Suman Anna
[not found] ` <1437431613-55656-1-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-07-20 22:33 ` [PATCH 01/11] Documentation: dt: Add #iommu-cells info to OMAP iommu bindings Suman Anna
[not found] ` <1437431613-55656-2-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-07-21 15:55 ` Laurent Pinchart
2015-07-20 22:33 ` [PATCH 02/11] iommu/omap: Remove all module references Suman Anna
[not found] ` <1437431613-55656-3-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-07-21 16:00 ` Laurent Pinchart
2015-07-21 23:44 ` Suman Anna
2015-07-20 22:33 ` [PATCH 03/11] iommu/omap: Move debugfs functions to omap-iommu-debug.c Suman Anna
2015-07-20 22:33 ` [PATCH 04/11] iommu/omap: Protect omap-iopgtable.h against double inclusion Suman Anna
[not found] ` <1437431613-55656-5-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-07-21 16:01 ` Laurent Pinchart [this message]
2015-07-20 22:33 ` [PATCH 05/11] iommu/omap: Remove unused union fields Suman Anna
2015-07-20 22:33 ` [PATCH 06/11] iommu/omap: Remove trailing semi-colon from a macro Suman Anna
2015-07-20 22:33 ` [PATCH 07/11] iommu/omap: Remove unnecessary error traces on alloc failures Suman Anna
[not found] ` <1437431613-55656-8-git-send-email-s-anna-l0cyMroinI0@public.gmane.org>
2015-07-21 16:03 ` Laurent Pinchart
2015-07-20 22:33 ` [PATCH 08/11] iommu/omap: Use BIT(x) macros in omap-iopgtable.h Suman Anna
2015-07-20 22:33 ` [PATCH 09/11] iommu/omap: Use BIT(x) macros in omap-iommu.h Suman Anna
2015-07-20 22:33 ` [PATCH 10/11] iommu/omap: Align code with open parenthesis Suman Anna
2015-07-20 22:33 ` [PATCH 11/11] iommu/omap: Split multiple assignments into separate lines Suman Anna
2015-08-03 13:55 ` [PATCH 00/11] Some OMAP IOMMU cleanup patches Joerg Roedel
[not found] ` <20150803135533.GH14980-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-08-03 16:12 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9915916.m7jlAc5up8@avalon \
--to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=s-anna-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.