From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1A69C5CFDB for ; Thu, 13 Aug 2026 10:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/BuHPpnzZHteKsYDuUbfARlxgNnfnDbxBH+K+gw6fwA=; b=WzgD/Xq9owG4k3BpDFN+d2qv8c TJ0Bfw1AJ19H6/m4cDuNQvuYdKf4R10b2gDcLtMNPVMnTbo0GXBEEhsvqWSXaVOuNq+poRiiNLtIa E3Ky+E8bPmNdr7UDUV/lNEC56lnG9i6+tcqVOdF1Pk3snQ2Fs3VP95C9w+xL5xZt5hiZhrW1psRMZ /6Yu6+KSzTw+iCVstXt3m3PBovRdFAtSWMOKsdalGHML316AwbkdQFHMEd7JWrEgLv6+qwnVzvRtL fR7qJdFcb4PJ6SX/lxnlCoERwKxdGAphjAweXxqDtEm1rGwlSN20wtLEiubDMXkB+KiArkuKqsABg V8/Xe7WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuSVN-00000000Rbj-2Z7C; Thu, 13 Aug 2026 10:17:45 +0000 Received: from mx.nabladev.com ([178.251.229.89]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuSVK-00000000RbA-3NqZ; Thu, 13 Aug 2026 10:17:44 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BE8F1112995; Thu, 13 Aug 2026 12:17:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1786616247; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=/BuHPpnzZHteKsYDuUbfARlxgNnfnDbxBH+K+gw6fwA=; b=UNgWn58Z7/RgRQnUiTN0w24Zxt47G2xD545mja3bMa1O29zmbIonUCe/pmi3b379YvLdnG D4wtCOg3j5fEz/XiYXbH1J8beRq6WTjZcKSkp6xen+e05mXvx6X/f1I2I5jZHGwUq9nMpO FCLTTZaYF7YiGNnxzamTK1yoFj8WgvixzW+6SQvpdOpNhlzSEQDNLssSebZrKEDxbv2RpF 4ufPn+CO/Bm1HBtbf/XVl/AaJ2NRJtK8zo3KCWxyLXWxUUDAd2dFdKGeI50Zv3UJq+l2HL JVNCpsuXSwijoIhVBm1V40Du/rNbhB2bryA+PnRr/wXg9gu+wq/B7bM69TPFjg== Message-ID: <9921697d-ea7a-42da-b172-54412082ec8f@nabladev.com> Date: Thu, 13 Aug 2026 12:17:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY To: Rob Herring Cc: Krzysztof Kozlowski , linux-usb@vger.kernel.org, Pankaj Dev , Fabrice Gasnier , Rahul Kumar , Alexandre Torgue , Christian Bruel , Conor Dooley , Greg Kroah-Hartman , Krzysztof Kozlowski , Maxime Coquelin , Neil Armstrong , Rosen Penev , Thinh Nguyen , Vinod Koul , devicetree@vger.kernel.org, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com References: <20260812010157.1772849-1-marex@nabladev.com> <20260812010157.1772849-2-marex@nabladev.com> <20260812-silky-omniscient-dalmatian-b268cb@quoll> <20260812225105.GB693080-robh@kernel.org> Content-Language: en-US From: Marek Vasut In-Reply-To: <20260812225105.GB693080-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260813_031743_094518_EF2FEADC X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/13/26 12:51 AM, Rob Herring wrote: > On Wed, Aug 12, 2026 at 08:30:33PM +0200, Marek Vasut wrote: >> On 8/12/26 1:22 PM, Krzysztof Kozlowski wrote: >>> On 12/08/2026 12:56, Marek Vasut wrote: >>>> On 8/12/26 12:15 PM, Krzysztof Kozlowski wrote: >>>>> On Wed, Aug 12, 2026 at 02:55:41AM +0200, Marek Vasut wrote: >>>>>> From: Pankaj Dev >>>>>> >>>>>> Document USB2 PHY for STM32MP25 USB2 controllers, which includes the >>>>>> USB2.0 host-only controller and USB 2.0 part of the DWC3 controller. >>>>>> Two such PHYs in total are present in STM32MP25 SoC, they both are >>>>>> slightly different, therefore they use different compatible string >>>>> >>>>> What is slightly different? This should be either here, or better, in >>>>> "description" part. >>>> >>>> They are both Synopsys FEMTO-PHY , but they are each attached to a >>>> different controller (one to USB 2.0 host , the other to DWC3 DRD) , and >>>> their control bits in the system controller register are different for >>>> each variant. >>>> >>>> I extended the description in V2. >>> >>> Depending on the actual difference, this rather belongs to the phandle >>> to syscon, instead of separate compatible. >> >> Modeling that in the phandle to syscon won't scale, the PHY driver is simple >> thus far and does not control all the bits in that syscon, if we were to >> somehow extend the phandle to syscon to describe the various bit mappings >> and differences in it, it would look awful quickly. Hence the separate >> compatible strings, so the driver can match on them, derive match data from >> them and use the match data to figure out differences of each instance. > > There's no 'reg' so the syscon is the only control interface, right? Correct. > So this should be child node of the syscon (with a reg property). All right, will do in V2 (already done locally). Thanks ! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12308C5B572 for ; Thu, 13 Aug 2026 10:17:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mUkcfN6tGyMp7jYe0GqisnrTSu4fwMmcEursvOa4mBw=; b=GrBvtslqfPMEG8 b259a+dEChUnaSSAaSgYF6MBXL7tkXxh95kQYNS517gfYs397V/JVO5reAGpPI9GcIw12623ho8qt Av2y7qbkS3BV72PHEIcdltLUmJkJQF4G/sCdAbthY1HyAasek70Mu1N8axSWOO0Jm0MOc4wRBMU0e 2OU08TWSAXaEu1b3r6b6cow467s3tjgjs1gP8a1TDSdWSpTWMsWN2c1/injZaJ2WEnp7/9XW+gf+Q RJhWTArdmV/wptyr+SVgg/hdWSTVaZQuYzXeg1/fFO7iQU2RjEcCPrnVH7RpK4gXI86rn9rs/WS0I fly8y9OvdtVkcXsO7R2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuSVN-00000000Rbq-2scB; Thu, 13 Aug 2026 10:17:45 +0000 Received: from mx.nabladev.com ([178.251.229.89]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuSVK-00000000RbA-3NqZ; Thu, 13 Aug 2026 10:17:44 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BE8F1112995; Thu, 13 Aug 2026 12:17:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1786616247; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=/BuHPpnzZHteKsYDuUbfARlxgNnfnDbxBH+K+gw6fwA=; b=UNgWn58Z7/RgRQnUiTN0w24Zxt47G2xD545mja3bMa1O29zmbIonUCe/pmi3b379YvLdnG D4wtCOg3j5fEz/XiYXbH1J8beRq6WTjZcKSkp6xen+e05mXvx6X/f1I2I5jZHGwUq9nMpO FCLTTZaYF7YiGNnxzamTK1yoFj8WgvixzW+6SQvpdOpNhlzSEQDNLssSebZrKEDxbv2RpF 4ufPn+CO/Bm1HBtbf/XVl/AaJ2NRJtK8zo3KCWxyLXWxUUDAd2dFdKGeI50Zv3UJq+l2HL JVNCpsuXSwijoIhVBm1V40Du/rNbhB2bryA+PnRr/wXg9gu+wq/B7bM69TPFjg== Message-ID: <9921697d-ea7a-42da-b172-54412082ec8f@nabladev.com> Date: Thu, 13 Aug 2026 12:17:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY To: Rob Herring Cc: Krzysztof Kozlowski , linux-usb@vger.kernel.org, Pankaj Dev , Fabrice Gasnier , Rahul Kumar , Alexandre Torgue , Christian Bruel , Conor Dooley , Greg Kroah-Hartman , Krzysztof Kozlowski , Maxime Coquelin , Neil Armstrong , Rosen Penev , Thinh Nguyen , Vinod Koul , devicetree@vger.kernel.org, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com References: <20260812010157.1772849-1-marex@nabladev.com> <20260812010157.1772849-2-marex@nabladev.com> <20260812-silky-omniscient-dalmatian-b268cb@quoll> <20260812225105.GB693080-robh@kernel.org> Content-Language: en-US From: Marek Vasut In-Reply-To: <20260812225105.GB693080-robh@kernel.org> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260813_031743_094518_EF2FEADC X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 8/13/26 12:51 AM, Rob Herring wrote: > On Wed, Aug 12, 2026 at 08:30:33PM +0200, Marek Vasut wrote: >> On 8/12/26 1:22 PM, Krzysztof Kozlowski wrote: >>> On 12/08/2026 12:56, Marek Vasut wrote: >>>> On 8/12/26 12:15 PM, Krzysztof Kozlowski wrote: >>>>> On Wed, Aug 12, 2026 at 02:55:41AM +0200, Marek Vasut wrote: >>>>>> From: Pankaj Dev >>>>>> >>>>>> Document USB2 PHY for STM32MP25 USB2 controllers, which includes the >>>>>> USB2.0 host-only controller and USB 2.0 part of the DWC3 controller. >>>>>> Two such PHYs in total are present in STM32MP25 SoC, they both are >>>>>> slightly different, therefore they use different compatible string >>>>> >>>>> What is slightly different? This should be either here, or better, in >>>>> "description" part. >>>> >>>> They are both Synopsys FEMTO-PHY , but they are each attached to a >>>> different controller (one to USB 2.0 host , the other to DWC3 DRD) , and >>>> their control bits in the system controller register are different for >>>> each variant. >>>> >>>> I extended the description in V2. >>> >>> Depending on the actual difference, this rather belongs to the phandle >>> to syscon, instead of separate compatible. >> >> Modeling that in the phandle to syscon won't scale, the PHY driver is simple >> thus far and does not control all the bits in that syscon, if we were to >> somehow extend the phandle to syscon to describe the various bit mappings >> and differences in it, it would look awful quickly. Hence the separate >> compatible strings, so the driver can match on them, derive match data from >> them and use the match data to figure out differences of each instance. > > There's no 'reg' so the syscon is the only control interface, right? Correct. > So this should be child node of the syscon (with a reg property). All right, will do in V2 (already done locally). Thanks ! -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy