All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirk Lee" <mpc@mail2000.com.tw>
To: "" <dwmw2@infradead.org>
Cc: "" <linux-mtd@lists.infradead.org>
Subject: Re: Patch to support TQM8xxL board
Date: Wed, 13 Jun 2001 01:00:28 +0800 (CST)	[thread overview]
Message-ID: <992365228.18352.mpc@mail2000.com.tw> (raw)

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

>> +dep_tristate '  CFI Flash device mapped on >>TQM8xxL' CONFIG_MTD_TQM8xxL $CONFIG_MTD_CFI >>$CONFIG_TQM8xxL
>It's normal to have config options in all >capitals. Also, we require a Configure.help entry >for this option.

 Fixed and also add related entry into Configure.help.

>>CFI_LITTLE_ENDIAN......
>Actually HOST_ENDIAN should also work, shouldn't it?

 I just take a rough try.
 HOST_ENDIAN does not work.
 TQM8xxL is a Embedded PowerPC based board, MPC8xx
 series, and ppc-linux for that series use 'lwbrx' 
 and 'stwbrx' instruction to implement 'readl'
 and 'writel'.
 This may be the reason, I guess.....

>> +#ifndef CONFIG_MTD_TQM8xxL
>> +#error This is for TQM8xxL platform only
>> +#endif
>Please omit this. It shouldn't be necessary.

 Fixed.

 Thanks

 kirk


----== Mailed via Openfind ==-----
http://mail2000.com.tw/ 提供免費電子郵件信箱


[-- Attachment #2: patch-mtd-snapshot20010610.gz --]
[-- Type: application/octet-stream, Size: 3454 bytes --]

             reply	other threads:[~2001-06-12 16:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-12 17:00 Kirk Lee [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-06-11 17:19 Patch to support TQM8xxL board Kirk Lee
2001-06-12  8:12 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=992365228.18352.mpc@mail2000.com.tw \
    --to=mpc@mail2000.com.tw \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.