From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 1/6] ethdev: fix port id storage
Date: Thu, 18 Jan 2018 12:29:40 +0100
Message-ID: <9933117.qs9VA5frF5@xps>
References: <20180109162317.18183-1-ferruh.yigit@intel.com>
 <2341214.iScQkZ5rM7@xps> <cc23d7b3-91f6-7196-469c-c72e7ab7c0a5@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, stable@dpdk.org, declan.doherty@intel.com,
 Boris Pismenny <borisp@mellanox.com>, Aviad Yehezkel <aviadye@mellanox.com>,
 Radu Nicolau <radu.nicolau@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <cc23d7b3-91f6-7196-469c-c72e7ab7c0a5@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

18/01/2018 11:15, Ferruh Yigit:
> On 1/17/2018 10:19 PM, Thomas Monjalon wrote:
> > 17/01/2018 23:09, Thomas Monjalon:
> >> 17/01/2018 22:57, Ferruh Yigit:
> >>> port_id is now 16bits, update function parameter according.
> >>>
> >>> Fixes: 4c270218aa26 ("ethdev: support security APIs")
> >>> Cc: stable@dpdk.org
> >>> Cc: declan.doherty@intel.com
> >>>
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> >>
> >> Obviously,
> >> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > 
> > Not so obvious actually.
> > It is a good fix, but an API change.
> 
> It is more like API fix.
> While whole library is using 16bits for port_id, I think we shouldn't deliver
> release with this specific API uses 8bits.
> 
> I am for getting this because what it does is wrong.
> 
> > This function was not declared experimental.
> > It must wait 18.05.

I really want to keep API stable in 18.02.
We have to keep this mistake for one more release.