All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hunter <david.hunter.linux@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	shuah@kernel.org, javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH 5/7] linux-kbuild: fix: implement choice for kconfigs
Date: Thu, 10 Oct 2024 16:29:56 -0400	[thread overview]
Message-ID: <994efba2-2829-4874-b5fa-9f5317f6ea6b@gmail.com> (raw)
In-Reply-To: <CAK7LNAQ8D4OVT81iTVs8jjrBXX6Zgwc+VJ_vb7hb4J-vCZZN=g@mail.gmail.com>

Apologies, I was a little too quick with the send button on my previous 
email. I forgot that I also wanted to respond to this part as well.

On 9/23/24 23:46, Masahiro Yamada wrote:

> I believe the only benefit to parse 'choice' block
> is to propagate its 'depends on' down to member configs.

I am not quite sure this statement is correct. I definitely agree that 
the main reason to parse the "choice" block is to propagate the 
"depends"; however, I believe that there is also information for 
defaults as well as for prompts inside the "choice" blocks.


I made a shell script that reads all of the choice blocks in the various 
Kconfig files. I wanted to know how many of each type of information is 
in there. Here are the results:

  - select: 0
  - prompts: 152
  - defaults: 156
  - depends: 72

Also, I should note that while there are no selects inside of a choice, 
I am unaware if this will always be the case in the future.

Here is a link to the shell script that I made:

https://github.com/dshunter107/linux-tools/blob/main/check_propagation.sh

Thanks,
David Hunter

  parent reply	other threads:[~2024-10-10 20:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 17:11 David Hunter
2024-09-13 17:11 ` [PATCH 1/7] linux-kbuild: fix: config option can be bool David Hunter
2024-09-24  2:55   ` Masahiro Yamada
2024-10-10 19:46     ` David Hunter
2024-10-14 14:22       ` David Hunter
2024-09-13 17:11 ` [PATCH 2/7] linux-kbuild: fix: missing variable operator David Hunter
2024-09-24  3:04   ` Masahiro Yamada
2024-10-14 14:26   ` David Hunter
2024-09-13 17:11 ` [PATCH 3/7] linux-kbuild: fix: ensure all defaults are tracked David Hunter
2024-09-24  3:06   ` Masahiro Yamada
2024-10-14 14:27   ` David Hunter
2024-09-13 17:11 ` [PATCH 4/7] linux-kbuild: fix: ensure selected configs were turned on in original David Hunter
2024-09-24  3:45   ` Masahiro Yamada
2024-10-14 14:38     ` David Hunter
2024-09-13 17:12 ` [PATCH 5/7] linux-kbuild: fix: implement choice for kconfigs David Hunter
2024-09-24  3:46   ` Masahiro Yamada
2024-10-10 20:06     ` David Hunter
2024-10-10 20:29     ` David Hunter [this message]
2024-10-14 14:39     ` David Hunter
2024-09-13 17:12 ` [PATCH 6/7] linux-kbuild: fix: configs with defaults do not need a prompt David Hunter
2024-09-24  4:08   ` Masahiro Yamada
2024-10-14 14:41     ` David Hunter
2024-09-13 17:12 ` [PATCH 7/7] linux-kbuild: fix: process config options set to "y" David Hunter
2024-09-24  4:21   ` Masahiro Yamada
2024-10-10 20:47     ` David Hunter
2024-10-14 14:42     ` David Hunter
2024-09-13 20:39 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=994efba2-2829-4874-b5fa-9f5317f6ea6b@gmail.com \
    --to=david.hunter.linux@gmail.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.