From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MaGRm-0005Br-If
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 18:00:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MaGRh-0005AF-Ir
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 18:00:57 -0400
Received: from [199.232.76.173] (port=50775 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MaGRh-0005A7-Dg
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 18:00:53 -0400
Received: from mail.gmx.net ([213.165.64.20]:56779)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1MaGRg-0000Gj-Hj
	for qemu-devel@nongnu.org; Sun, 09 Aug 2009 18:00:53 -0400
Message-ID: <995EB2524B354E00A17BA598EF23C718@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <CB9C1DB604194FD4B20F3055C9363217@FSCPC>
	<5b31733c0908090526w6594523dvff8b6cbce3f80277@mail.gmail.com>
In-Reply-To: <5b31733c0908090526w6594523dvff8b6cbce3f80277@mail.gmail.com>
Date: Mon, 10 Aug 2009 00:00:08 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Work around stdio redirection by SDL on
	Windows
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org

Filip Navara wrote:
>> Sebastian Herbszt wrote:
>> --- v0.11.0-rc0-201-gd9c3231/vl.c.orig Sun Aug 9 11:52:47 2009
>> +++ v0.11.0-rc0-201-gd9c3231/vl.c Sun Aug 9 11:58:59 2009
>> @@ -4873,6 +4873,12 @@
>> CPUState *env;
>> int show_vnc_port = 0;
>>
>> +/* Work around stdio redirection by SDL on Windows */
>> +#if defined (CONFIG_SDL) && defined (_WIN32)
>> + freopen("CON", "wb", stdout);
>> + freopen("CON", "wb", stderr);
>> +#endif
>> +
>
> That will not work in RXVT, SSH consoles and for pipes unfortunately
> :-/ Also it won't respect the redirections specified on command line,
> which is something I often use, therefore I object to this patch. It's
> better to use SDL compiled with the --enable-stdio-redirect=no option.

Too bad this work around is a no go. At least for me it's good enough to
make qemu usable again.

I hope the need for a custom SDL will at least get properly documented since
this is a big regression for Windows users.

- Sebastian